[PATCH] hash: Allow building with the external sha1dc library

2017-07-24 Thread Takashi Iwai
ha1dc library instead of the built-in sha1dc code. User needs to define DC_SHA1_EXTERNAL explicitly. As default, the built-in sha1dc code is used like before. Signed-off-by: Takashi Iwai --- Makefile | 12 hash.h | 4 +++- sha1dc_git_ext.c

Re: [PATCH] hash: Allow building with the external sha1dc library

2017-07-31 Thread Takashi Iwai
On Fri, 28 Jul 2017 17:58:14 +0200, Ævar Arnfjörð Bjarmason wrote: > > On Tue, Jul 25, 2017 at 7:57 AM, Takashi Iwai wrote: > > Some distros provide SHA1 collision detect code as a shared library. > > It's the very same code as we have in git tree, and git can link with &

Re: [PATCH] hash: Allow building with the external sha1dc library

2017-07-31 Thread Takashi Iwai
On Fri, 28 Jul 2017 18:04:18 +0200, Ævar Arnfjörð Bjarmason wrote: > > On Fri, Jul 28, 2017 at 5:58 PM, Ævar Arnfjörð Bjarmason > wrote: > > On Tue, Jul 25, 2017 at 7:57 AM, Takashi Iwai wrote: > >> Some distros provide SHA1 collision detect code as a shared library.

Re: [PATCH] hash: Allow building with the external sha1dc library

2017-08-01 Thread Takashi Iwai
On Tue, 01 Aug 2017 17:56:00 +0200, Junio C Hamano wrote: > > Takashi Iwai writes: > > > On Fri, 28 Jul 2017 17:58:14 +0200, > > Ævar Arnfjörð Bjarmason wrote: > >> ... > >> * We now have much of the same header code copy/pasted between > >> sha

Re: [PATCH] hash: Allow building with the external sha1dc library

2017-08-01 Thread Takashi Iwai
On Tue, 01 Aug 2017 21:55:45 +0200, Ævar Arnfjörð Bjarmason wrote: > > > On Tue, Aug 01 2017, Takashi Iwai jotted: > > > On Tue, 01 Aug 2017 17:56:00 +0200, > > Junio C Hamano wrote: > >> > >> Takashi Iwai writes: > >> > >> > On

Re: [PATCH] hash: Allow building with the external sha1dc library

2017-08-11 Thread Takashi Iwai
On Sat, 12 Aug 2017 02:42:25 +0200, Junio C Hamano wrote: > > Ævar Arnfjörð Bjarmason writes: > > > On Fri, Jul 28, 2017 at 5:58 PM, Ævar Arnfjörð Bjarmason > > wrote: > > > > I sent this last bit a tad too soon in a checkout of > > sha1collisiondetection.git: > > > > $ make PREFIX=/tmp/l

[PATCH v2 1/2] sha1dc: Build git plumbing code more explicitly

2017-08-15 Thread Takashi Iwai
ernal sha1dc shlib. Signed-off-by: Takashi Iwai --- Makefile | 5 ++--- hash.h | 6 +- sha1dc_git.c | 9 ++--- sha1dc_git.h | 18 +++--- 4 files changed, 16 insertions(+), 22 deletions(-) diff --git a/Makefile b/Makefile index 461c845d33cb..5e7e9022bdd8 100644

[PATCH v2 2/2] sha1dc: Allow building with the external sha1dc library

2017-08-15 Thread Takashi Iwai
er to build git linking with the external sha1dc library instead of the built-in code. User needs to define DC_SHA1_EXTERNAL explicitly. As default without it, the built-in sha1dc code is used like before. Signed-off-by: Takashi Iwai --- Makefile | 13 + sha1dc_git.c

[PATCH v2 0/2] Allow building with the external sha1dc library

2017-08-15 Thread Takashi Iwai
merged commonly in sha1dc_git.[ch] - Check the conflict of extlib vs submodule - Drop DC_SHA1_LINK, hoping that everyone is well-mannered - Minor rephrasing / corrections of texts thanks, Takashi === Takashi Iwai (2): sha1dc: Build git plumbing code more explicitly sha1dc: Allow building

glibc mutex deadlock in signal handler

2015-09-03 Thread Takashi Iwai
Hi, we've got a bug report of git-log stall in below: https://bugzilla.opensuse.org/show_bug.cgi?id=942297 In short, git-log is left unterminated sometimes when pager is aborted. When this happens, git process can't be killed by SIGTERM, but only by SIGKILL. And, further investigation reveale

Re: glibc mutex deadlock in signal handler

2015-09-03 Thread Takashi Iwai
On Thu, 03 Sep 2015 20:12:38 +0200, Junio C Hamano wrote: > > Takashi Iwai writes: > > > we've got a bug report of git-log stall in below: > > https://bugzilla.opensuse.org/show_bug.cgi?id=942297 > > > > In short, git-log is left unterminated sometimes

Re: glibc mutex deadlock in signal handler

2015-09-03 Thread Takashi Iwai
e. FWIW, below is the updated patch with a proper change log. Takashi -- 8< -- From: Takashi Iwai Subject: [PATCH] pager: don't use unsafe functions in signal handlers Since the commit [a3da8821208d: pager: do wait_for_pager on signal death], we call wait_for_pager() in the pager'

Re: glibc mutex deadlock in signal handler

2015-09-04 Thread Takashi Iwai
On Fri, 04 Sep 2015 11:23:55 +0200, Jeff King wrote: > > On Fri, Sep 04, 2015 at 07:52:21AM +0200, Takashi Iwai wrote: > > > -- 8< -- > > From: Takashi Iwai > > Subject: [PATCH] pager: don't use unsafe functions in signal handlers > > >

Re: glibc mutex deadlock in signal handler

2015-09-04 Thread Takashi Iwai
On Fri, 04 Sep 2015 15:04:48 +0200, Jeff King wrote: > > On Fri, Sep 04, 2015 at 11:35:57AM +0200, Takashi Iwai wrote: > > > > Hmm, is there is any reason to just pass an "in_signal" flag to > > > wait_for_pager(), to avoid duplicating the logic? > >

[PATCH 4/4] gitk: Add accelerator to German locale

2015-10-20 Thread Takashi Iwai
Assigned either to the first letter or some unique letter. At least there are no conflicts, as far as I see... Signed-off-by: Takashi Iwai --- gitk-git/po/de.po | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/gitk-git/po/de.po b/gitk

[PATCH 2/4] gitk: Update msgid's for menu items with accelerator

2015-10-20 Thread Takashi Iwai
contents aren't changed, so the accelerator won't work in these locales for now. Each locale translator needs to add proper acceleration keys appropriately. Signed-off-by: Takashi Iwai --- gitk-git/po/bg.po| 34 +-

[PATCH 0/4] gitk crash fix and locale updates

2015-10-20 Thread Takashi Iwai
Hi, the recent change in gitk to support the menu accelerator broke the invocation with --all option in non-English locales. Also, the whole menu translations are gone by this, too. This patchset tries to address these issues. Takashi === Takashi Iwai (4): gitk: Fix crash with --all in

[PATCH 1/4] gitk: Fix crash with --all in non-English locales

2015-10-20 Thread Takashi Iwai
match any longer with the new string containing accelerator mark (&). This patch corrects these strings. Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=951153 Signed-off-by: Takashi Iwai --- gitk-git/gitk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gitk-git/gitk b

[PATCH 3/4] gitk: Add accelerators to Japanese locale

2015-10-20 Thread Takashi Iwai
Just follow the English accelerator keys. Signed-off-by: Takashi Iwai --- gitk-git/po/ja.po | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/gitk-git/po/ja.po b/gitk-git/po/ja.po index 9bbbadd3b427..59e42a89fd7e 100644 --- a/gitk-git/po

Re: [GIT PULL] sound fixes for 3.6-rc6

2012-09-13 Thread Takashi Iwai
At Thu, 13 Sep 2012 19:51:14 +0800, Linus Torvalds wrote: > > On Thu, Sep 13, 2012 at 7:43 PM, Takashi Iwai wrote: > > are available in the git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-linus > > *PLEASE* don't

Re: [GIT PULL] sound fixes for 3.6-rc6

2012-09-13 Thread Takashi Iwai
At Thu, 13 Sep 2012 14:03:16 +0200, Takashi Iwai wrote: > > At Thu, 13 Sep 2012 19:51:14 +0800, > Linus Torvalds wrote: > > > > On Thu, Sep 13, 2012 at 7:43 PM, Takashi Iwai wrote: > > > are available in the git repository at: > > > > > > git

Re: [GIT PULL] sound fixes for 3.6-rc6

2012-09-13 Thread Takashi Iwai
At Thu, 13 Sep 2012 09:03:44 -0400, Jeff King wrote: > > On Thu, Sep 13, 2012 at 02:28:51PM +0200, Takashi Iwai wrote: > > > > FWIW, it was an output from git-pull-request, which fell back to the > > > equivalent branch. Usually I check it manually but I forgot it at

Re: [GIT PULL] sound fixes for 3.6-rc6

2012-09-13 Thread Takashi Iwai
At Thu, 13 Sep 2012 08:14:27 -0700, Junio C Hamano wrote: > > Takashi Iwai writes: > > >> I can't reproduce here. What is your exact request-pull invocation? > > This question was not answerd. It was (a sort of), but let me clarify again. In my original pull re

Re: ASoC updates for v3.8

2012-12-17 Thread Takashi Iwai
At Mon, 17 Dec 2012 14:25:00 +, Mark Brown wrote: > > On Mon, Dec 17, 2012 at 03:09:34PM +0100, Takashi Iwai wrote: > > At Mon, 17 Dec 2012 22:14:10 +0900, > > Mark Brown wrote: > > > > > > The following changes since commit > >