Re: [PATCH v2 0/2] make commit --verbose work with --no-status

2015-06-05 Thread Tay Ray Chuan
Hi Junio, On Fri, Jun 5, 2015 at 2:39 AM, Junio C Hamano gits...@pobox.com wrote: Tay Ray Chuan rcta...@gmail.com writes: When running git-commit`, --verbose appends a diff to the prepared message, while --no-status omits git-status output. The --verbose option is called --verbose

Re: [PATCH v2 0/2] make commit --verbose work with --no-status

2015-06-05 Thread Tay Ray Chuan
On Sat, Jun 6, 2015 at 12:03 AM, Junio C Hamano gits...@pobox.com wrote: Tay Ray Chuan rcta...@gmail.com writes: Would it be a good idea to have a --diff-only option to include diff, but not status output? Or perhaps a --diff option, while leaving it to the user to specify if status output

[PATCH v2 2/2] make commit --verbose work with --no-status

2015-06-04 Thread Tay Ray Chuan
, which triggers the setting of the commitable flag, and the printing of the diff. This is set only by git-commit, and when it detects that --verbose and --no-status have been used. Signed-off-by: Tay Ray Chuan rcta...@gmail.com --- Changed since v1: adopted peff's suggestion in 20140224083312.gb32

[PATCH v2 1/2] extract setting of wt_status.commitable flag out of wt_status_print_updated()

2015-06-04 Thread Tay Ray Chuan
It may not be obvious from its name that wt_status_print_updated() that it also sets wt_status.commitable, which affects commit functionality. Extract this out into a separate function for improved clarity, though at the expense of executing another loop. Signed-off-by: Tay Ray Chuan rcta

[PATCH v2 0/2] make commit --verbose work with --no-status

2015-06-04 Thread Tay Ray Chuan
When running git-commit`, --verbose appends a diff to the prepared message, while --no-status omits git-status output; thus, one would expect --verbose --no-status to give a commit message with a diff of the commit without git-status output. However, this is not what happens - the prepared commit

Re: [msysGit] Re: Sneak peek of the upcoming Git for Windows 2.x

2015-04-13 Thread Tay Ray Chuan
Hi Rupert, On Mon, Apr 13, 2015 at 1:51 AM, Johannes Schindelin johannes.schinde...@gmx.de wrote: On 2015-04-11 10:37, rupert thurner wrote: * the prompt is still as slow as before, calculating the branch name on pressing return without option to turn it off There is no explicit option in

Re: [PATCH] git-completion.bash - avoid excruciatingly slow ref completion on Cygwin

2014-10-18 Thread Tay Ray Chuan
On Sat, Oct 11, 2014 at 11:51 PM, Mark Levedahl mleved...@gmail.com wrote: $git checkout tab was taking about 3.5 seconds to respond on one repository having four remotes with about 100 total refs (measured on Cygwin). All of the time was being claimed in git for-each-ref to do its work.

Re: [PATCH] Replace memcpy with hashcpy when dealing hash copy globally

2014-03-01 Thread Tay Ray Chuan
On Sat, Mar 1, 2014 at 10:58 AM, Duy Nguyen pclo...@gmail.com wrote: On Sat, Mar 1, 2014 at 8:07 AM, Sun He sunheeh...@gmail.com wrote: Signed-off-by: Sun He sunheeh...@gmail.com --- Find the potential places with memcpy by the bash command: $ find . | xargs grep memcpy.*\(.*20.*\)

Re: GSoC idea: allow git rebase --interactive todo lines to take options

2014-02-26 Thread Tay Ray Chuan
On Wed, Feb 26, 2014 at 6:52 PM, Jeff King p...@peff.net wrote: I'd worry a little that it is not a summer's worth of work, but I suspect there are other parts of rebase--interactive that could use attention once the student is familiar with the code. It might be worthwhile to check for prior

Re: [PATCH 3/3] make commit --verbose work with --no-status

2014-02-23 Thread Tay Ray Chuan
On Sat, Feb 22, 2014 at 4:31 PM, Jeff King p...@peff.net wrote: On Sat, Feb 22, 2014 at 03:09:22AM +0800, Tay Ray Chuan wrote: @@ -1141,7 +1146,12 @@ static int parse_and_validate_options(int argc, const char *argv[], if (all argc 0) die(_(Paths with -a does not make

[PATCH 1/3] rename STATUS_FORMAT_NONE to STATUS_FORMAT_DEFAULT

2014-02-21 Thread Tay Ray Chuan
Cc: Jeff King p...@peff.net In f3f47a1 (status: add --long output format option), STATUS_FORMAT_NONE was introduced, meaning the user did not specify anything. Rename this to *_DEFAULT to better indicate its meaning. This paves the way for _NONE to really mean no status. Signed-off-by: Tay Ray

[PATCH 0/3] make commit --verbose work with --no-status

2014-02-21 Thread Tay Ray Chuan
One would expect 'git commit --verbose --no-status' to give a commit message with a diff of the commit, sans the output of git-status. However, this does not work currently; the commit message body is entirely empty (diff is absent as well). This patch series attempts to make this work, as one

[PATCH 2/3] extract setting of wt_status.commitable flag out of wt_status_print_updated()

2014-02-21 Thread Tay Ray Chuan
contributors would outweigh the performance penalty. Signed-off-by: Tay Ray Chuan rcta...@gmail.com --- wt-status.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/wt-status.c b/wt-status.c index a452407..9b0189c 100644 --- a/wt-status.c +++ b/wt-status.c

[PATCH 3/3] make commit --verbose work with --no-status

2014-02-21 Thread Tay Ray Chuan
, and ii) --no-status. Signed-off-by: Tay Ray Chuan rcta...@gmail.com --- builtin/commit.c | 14 +- wt-status.c | 2 +- wt-status.h | 3 +++ 3 files changed, 17 insertions(+), 2 deletions(-) diff --git a/builtin/commit.c b/builtin/commit.c index 2e86b76..fca6a6b 100644

[PATCH] demonstrate git-commit --dry-run exit code behaviour

2014-02-21 Thread Tay Ray Chuan
a matter of calling wt_status_mark_commitable(). [1] http://article.gmane.org/gmane.comp.version-control.git/242489 Signed-off-by: Tay Ray Chuan rcta...@gmail.com --- t/t7501-commit.sh | 36 1 file changed, 36 insertions(+) diff --git a/t/t7501-commit.sh b/t

Re: git svn clone not work. It's stop with no error message.

2014-02-17 Thread Tay Ray Chuan
Posting to msysgit since this was on Windows. -- Cheers, Ray Chuan On Mon, Feb 17, 2014 at 3:45 PM, youngseonkim 1.youngsun@gmail.com wrote: Hi, I really wonder about this happen. I want svn→git migrate, and I use this command. git svn clone https://my.svn.repo/url --stdlayout When I

[PATCH] drop unnecessary copying in credential_ask_one

2014-01-01 Thread Tay Ray Chuan
We were leaking memory in there, as after obtaining a string from git_getpass, we returned a copy of it, yet no one else held the original string, apart from credential_ask_one. Signed-off-by: Tay Ray Chuan rcta...@gmail.com --- credential.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] git-subtree: Avoid using echo -n even indirectly

2013-10-09 Thread Tay Ray Chuan
On Wed, Oct 9, 2013 at 11:57 AM, Paolo G. Giarrusso p.giarru...@gmail.com wrote: diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh index 7d7af03..ebfb78f 100755 --- a/contrib/subtree/git-subtree.sh +++ b/contrib/subtree/git-subtree.sh @@ -592,7 +592,9 @@ cmd_split()

Re: Dead links, broken search box, confusing/inconvenient contact

2013-10-04 Thread Tay Ray Chuan
On Fri, Oct 4, 2013 at 1:50 AM, Stefan Pochmann stefan.pochm...@gmail.com wrote: 4) When I found this email address and sent a mail with items 1)-3), I got a rejection reply saying The message contains HTML subpart. Very annoying. I'm trying to help here by pointing out problems, and you're

Re: [PATCH v2 0/5] New hash table implementation

2013-09-24 Thread Tay Ray Chuan
Hi Karsten, On Tue, Sep 24, 2013 at 5:50 PM, Karsten Blees karsten.bl...@gmail.com wrote: | add| get 100% hits |get 10% hits | hash | hashmap | hash | hashmap | hash | hashmap ++-+---+-+-+ FNV |

Re: [PATCH 3/3] git submodule update should give notice when run without init beforehand

2013-09-18 Thread Tay Ray Chuan
On Tue, Sep 17, 2013 at 1:06 AM, Jens Lehmann jens.lehm...@web.de wrote: Thanks Jens for having a look! Am 15.09.2013 19:38, schrieb Tay Ray Chuan: When 'update' is run with no path in a repository with uninitialized submodules, the program terminates with no output, and zero status code

[PATCH 2/3] t7406-submodule-update: demonstrate behaviour when run without init beforehand

2013-09-15 Thread Tay Ray Chuan
Signed-off-by: Tay Ray Chuan rcta...@gmail.com --- t/t7406-submodule-update.sh | 20 1 file changed, 20 insertions(+) diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh index f0b3305..00475eb 100755 --- a/t/t7406-submodule-update.sh +++ b/t/t7406

[PATCH 3/3] git submodule update should give notice when run without init beforehand

2013-09-15 Thread Tay Ray Chuan
When 'update' is run with no path in a repository with uninitialized submodules, the program terminates with no output, and zero status code. Be more helpful to users by mentioning this. This may be controlled by an advice.* option. Signed-off-by: Tay Ray Chuan rcta...@gmail.com

[PATCH 1/3] t7406-submodule-update: add missing

2013-09-15 Thread Tay Ray Chuan
322bb6e (2011 Aug 11) introduced a new subshell at the end of a test case but omitted a '' to join the two; fix this. Signed-off-by: Tay Ray Chuan rcta...@gmail.com --- t/t7406-submodule-update.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t7406-submodule-update.sh b/t

[PATCH 12/14] reduce confusion over smart server response behaviour

2013-09-10 Thread Tay Ray Chuan
-off-by: Tay Ray Chuan rcta...@gmail.com --- Documentation/technical/http-protocol.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/technical/http-protocol.txt b/Documentation/technical/http-protocol.txt index 4bb1614..63a089a 100644 --- a/Documentation

[PATCH 02/14] normalize indentation with protcol-common.txt

2013-09-10 Thread Tay Ray Chuan
Indent client/server query examples with 3 spaces. Indent ABNF rules with 2 spaces. Signed-off-by: Tay Ray Chuan rcta...@gmail.com -- This is in its own patch to minimize noise in diffs. --- Documentation/technical/http-protocol.txt | 226 +++--- 1 file changed, 113

[PATCH 05/14] drop rules, etc. common to the pack protocol

2013-09-10 Thread Tay Ray Chuan
Use obj-id in lieu of id (defined as 40*HEX). Use zero-id in lieu of 40*0. Use refname in lieu of name (not defined). Drop section on capabilities, since they are already available in protocol-capabilities.txt. Signed-off-by: Tay Ray Chuan rcta...@gmail.com -- pkt-line format section

[PATCH 08/14] mention different variations around $GIT_URL

2013-09-10 Thread Tay Ray Chuan
as encouraging such mind-boggling setups. While providing an example $GIT_URL containing a '?' (the catch-all gateway one), also mention a possible contradiction between the exactly-one-param requirement and the http client implementation in Git. Signed-off-by: Tay Ray Chuan rcta...@gmail.com

[PATCH 11/14] be clearer in place of 'remote repository' phrase

2013-09-10 Thread Tay Ray Chuan
the repository served by the server, but if it were named without upload-pack, I might have mistaken that you are allowing to proxy a request to access a third-party repository by this server. The same comment applies to the git-receive-pack service. Signed-off-by: Tay Ray Chuan rcta

[PATCH 10/14] fix example request/responses

2013-09-10 Thread Tay Ray Chuan
Add LF for responses. For smart interactions, add pkt-line lengths and the flush-pkt () line. Drop the SP that followed NUL before capability list. Signed-off-by: Tay Ray Chuan rcta...@gmail.com --- Documentation/technical/http-protocol.txt | 35 --- 1 file

[PATCH 14/14] mention effect of allow-tip-sha1-in-want capability on git-upload-pack

2013-09-10 Thread Tay Ray Chuan
From: Nguyễn Thái Ngọc Duy pclo...@gmail.com Signed-off-by: Tay Ray Chuan rcta...@gmail.com Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com -- Subject crafted by Ray Chuan, Nguyễn's s-o-b lifted from 1377092713-25434-1-git-send-email-pclo...@gmail.com. --- Documentation/technical/http

[PATCH 03/14] capitalize key words according to RFC 2119

2013-09-10 Thread Tay Ray Chuan
Signed-off-by: Tay Ray Chuan rcta...@gmail.com --- Documentation/technical/http-protocol.txt | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/Documentation/technical/http-protocol.txt b/Documentation/technical/http-protocol.txt index 70a1648..55753bb 100644

[PATCH 00/14] document edits to original http protocol documentation

2013-09-10 Thread Tay Ray Chuan
This patch series are the changes based on the discussion on Shawn's original text [1]. Some of them are minor, while some may potentially change behaviour; see below for a classification of the changes. Hopefully they can be examined by the git contributors here. An earlier iteration of this

[PATCH 06/14] reword behaviour on missing repository or objects

2013-09-10 Thread Tay Ray Chuan
From: Shawn O. Pearce spea...@spearce.org Signed-off-by: Tay Ray Chuan rcta...@gmail.com -- To Shawn: sign-off-by needed. Based on: From: Shawn O. Pearce spea...@spearce.org Message-ID: 20091016142135.gr10...@spearce.org Mike Hommey m...@glandium.org wrote: On Thu, Oct 15, 2009 at 10

[PATCH 04/14] normalize rules with RFC 5234

2013-09-10 Thread Tay Ray Chuan
Drop LF, SP which are defined in RFC 5234. Replace HT with HTAB (also defined in the RFC). Use '/' instead of '|', as the RFC does. Signed-off-by: Tay Ray Chuan rcta...@gmail.com --- Documentation/technical/http-protocol.txt | 26 +- 1 file changed, 9 insertions(+), 17

[PATCH 01/14] Document the HTTP transport protocol

2013-09-10 Thread Tay Ray Chuan
From: Shawn O. Pearce spea...@spearce.org Signed-off-by: Shawn O. Pearce spea...@spearce.org Signed-off-by: Tay Ray Chuan rcta...@gmail.com -- This is the original 1255065768-10428-2-git-send-email-spea...@spearce.org with some minor changes, as follows: - fix mis-spelling 'paramterized

Re: coming from git, understanding mercurial branching

2013-09-05 Thread Tay Ray Chuan
On Fri, Sep 6, 2013 at 10:27 AM, Tim Chase g...@tim.thechases.com wrote: I've got a pretty good grasp on git's rather straightforward branching, but am trying to wrap my head around Mercurial's branching. There seem to be several flavors, some default to push-public, while others are private;

Re: Problems with Windows, Was: What's cooking in git.git (May 2013, #01; Fri, 3)

2013-05-15 Thread Tay Ray Chuan
On Wed, May 15, 2013 at 3:37 AM, Torsten Bögershausen tbo...@web.de wrote: Second, I was able to do some testing. The hanging is not 100% reproducable, and I had one hanging in Git 1.8.1 Turning the screen saver off in Win XP helps that the machine reacts, and using process explorer showed

Re: Can't Open Git

2013-05-10 Thread Tay Ray Chuan
Hi, You need to start Terminal to use git. eg. $ git init foo creates a git repo in the folder named foo. You can get a GUI to run git too: http://git-scm.com/downloads/guis -- Cheers, Ray Chuan On Fri, May 10, 2013 at 1:49 PM, Esther Hwang ehwang...@gmail.com wrote: Hi, I just

Re: Zile as git core editor?

2013-04-26 Thread Tay Ray Chuan
Hi, Is the GIT_EDITOR or EDITOR environment variable set? They may be overriding the core.editor setting. -- Cheers, Ray Chuan On Fri, Apr 26, 2013 at 3:39 PM, Thorsten Jolitz tjol...@gmail.com wrote: Hi List, after experiencing one crash to many, I'm back to Standard Emacs (instead of

Re: [BUG] git-clone fails due to GnuTLS recv error (-9), then deletes entire local repo

2013-04-15 Thread Tay Ray Chuan
On Fri, Feb 1, 2013 at 5:00 PM, TJ g...@iam.tj wrote: Using Ubuntu Precise 12.04 with git version (1.8.0.3) I discovered a bug whereby git-clone deletes the repository it has just created if there is a GnuTLS error after the final transfer. I switched to building and using the current git

Re: git rebase : knowing where I am...

2013-04-11 Thread Tay Ray Chuan
On Wed, Apr 10, 2013 at 4:40 PM, Jeremy Rosen jeremy.ro...@openwide.fr wrote: is there some way to know how far you are within a rebase when the rebase is interupted by a conflict other than the message given by git rebase when it was interrupted ? How about $ cat .git/rebase-merge/done

Re: git log -p unexpected behaviour - security risk?

2013-04-11 Thread Tay Ray Chuan
On Thu, Apr 11, 2013 at 6:36 PM, John Tapsell johnf...@gmail.com wrote: I noticed that code that you put in merge will not be visible by default. This seems like a pretty horrible security problem, no? I made the following test tree, with just 3 commits:

Re: [PATCH 6/6] remote.c: introduce branch.name.pushremote

2013-03-20 Thread Tay Ray Chuan
On Wed, Mar 20, 2013 at 8:45 PM, Ramkumar Ramachandra artag...@gmail.com wrote: This new configuration variable overrides `remote.pushdefault` and `branch.name.remote` for pushes. In a typical triangular-workflow setup, you would want to set `remote.pushdefault` to specify the remote to push

Re: [PATCH v2 0/6] Support triangular workflows

2013-03-20 Thread Tay Ray Chuan
On Wed, Mar 20, 2013 at 8:44 PM, Ramkumar Ramachandra artag...@gmail.com wrote: remote.c: introduce remote.pushdefault remote.c: introduce branch.name.pushremote Perhaps we should clarify how this differs from remote.pushurl in the documentation for it, in git-config and/or git-push. Maybe

Re: Debugging a bizarre problem: What can influence 'git fetch'?

2013-03-02 Thread Tay Ray Chuan
On Fri, Mar 1, 2013 at 10:39 PM, git-us...@io7m.com wrote: Is there some way to get 'git fetch' to be more verbose? It seems that the remote is running the 'dumb' http protocol, you might want to try setting the GIT_CURL_VERBOSE environment variable for more verbosity. Have you tried running

Re: [PATCH 2/3] combine-diff: suppress a clang warning

2013-02-03 Thread Tay Ray Chuan
On Sun, Feb 3, 2013 at 10:37 PM, John Keeping j...@keeping.me.uk wrote: When compiling combine-diff.c, clang 3.2 says: combine-diff.c:1006:19: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int] prefix = COLONS + offset;

Re: Wrap commit messages on `git commit -m`

2012-11-04 Thread Tay Ray Chuan
On Thu, Nov 1, 2012 at 11:29 AM, Lars Gullik Bjønnes lar...@gullik.org wrote: Ramkumar Ramachandra artag...@gmail.com writes: | Hi, | Some of my colleagues are lazy to fire up an editor and write proper | commit messages- they often write one-liners using `git commit -m`. | However, that

Re: [PATCH] Avoid crippled getpass function on Solaris

2012-08-06 Thread Tay Ray Chuan
On Tue, Aug 7, 2012 at 8:35 AM, Jeff King p...@peff.net wrote: Subject: [PATCH] terminal: seek when switching between reading and writing When a stdio stream is opened in update mode (e.g., w+), the C standard forbids switching between reading or writing without an intervening positioning

[PATCH v3 0/2] allow recovery from command name typos

2012-08-05 Thread Tay Ray Chuan
As discussed in the previous iteration, testing for prompt-availabilty has been reworked (patch #2). This is done with the aid of patch #1, which extracts the opening of /dev/tty from git_terminal_prompt() into a terminal_open(). Its return value indicates if a terminal is available for

[PATCH v3 1/2] add interface for /dev/tty interaction

2012-08-05 Thread Tay Ray Chuan
, as getpass() uses them both. Signed-off-by: Tay Ray Chuan rcta...@gmail.com --- compat/terminal.c | 52 compat/terminal.h | 10 ++ 2 files changed, 54 insertions(+), 8 deletions(-) diff --git a/compat/terminal.c b/compat/terminal.c index

[PATCH v3 2/2] allow recovery from command name typos

2012-08-05 Thread Tay Ray Chuan
; if unset, advise the user about this ability. Helped-by: Thomas Rast tr...@student.ethz.ch Signed-off-by: Tay Ray Chuan rcta...@gmail.com --- Changed in v3: - say do_* instead of shall_* - use new terminal interface Documentation/config.txt | 30 - advice.c | 2

Re: [PATCH] Avoid crippled getpass function on Solaris

2012-08-05 Thread Tay Ray Chuan
On Mon, Aug 6, 2012 at 7:17 AM, Ben Walton bwal...@artsci.utoronto.ca wrote: I've also briefly dabbled with getting Solaris to simply use the HAVE_DEV_TTY code path but the terminal echo stuff hasn't worked nicely for me just yet. (It reads the password with nothing echoed but then displays

[PATCH v2 0/4] allow recovery from command name typos

2012-07-25 Thread Tay Ray Chuan
@thomas.inf.ethz.ch Jeff King (1): help.c::uniq: plug a leak Tay Ray Chuan (3): help.c::exclude_cmds: realloc() before copy, plug a leak help.c: plug leaks with(out) help.autocorrect allow recovery from command name typos Documentation/config.txt | 30 advice.c | 2

[PATCH v2 2/4] help.c::exclude_cmds: realloc() before copy, plug a leak

2012-07-25 Thread Tay Ray Chuan
accessible anyway. Signed-off-by: Tay Ray Chuan rcta...@gmail.com --- help.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/help.c b/help.c index 6991492..dfb2e9d 100644 --- a/help.c +++ b/help.c @@ -20,6 +20,17 @@ void add_cmdname(struct cmdnames *cmds

[PATCH v2 4/4] allow recovery from command name typos

2012-07-25 Thread Tay Ray Chuan
; if unset, advise the user about this ability. Signed-off-by: Tay Ray Chuan rcta...@gmail.com --- Changed in v2: implement Thomas' idea [1] to hijack help.autocorrect to configure this behaviour. [1] 878vh4con4@thomas.inf.ethz.ch --- Documentation/config.txt | 30