Re: [PATCH v1 06/25] contrib: remove 'diffall'

2014-05-09 Thread Tim Henigan
On Thu, May 8, 2014 at 5:58 PM, Felipe Contreras felipe.contre...@gmail.com wrote: No activity since 2010, no tests. Cc: Tim Henigan tim.heni...@gmail.com Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- contrib/diffall/README | 31 -- contrib/diffall/git-diffall

Re: [PATCH v1 06/25] contrib: remove 'diffall'

2014-05-09 Thread Tim Henigan
Hi Jonathan, On Fri, May 9, 2014 at 11:50 AM, Jonathan Nieder jrnie...@gmail.com wrote: Hi Tim, Tim Henigan wrote: On Thu, May 8, 2014 at 5:58 PM, Felipe Contreras felipe.contre...@gmail.com wrote: contrib/diffall/README | 31 -- contrib/diffall/git-diffall | 257

Re: [PATCH v2 04/17] contrib: remove 'diffall'

2014-05-09 Thread Tim Henigan
On Fri, May 9, 2014 at 12:11 PM, Felipe Contreras felipe.contre...@gmail.com wrote: There is no more need for this tool since the --dir-dirr option was introduced. s/--dir-dirr/--dir-diff/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to

Re: [PATCH v1 06/25] contrib: remove 'diffall'

2014-05-09 Thread Tim Henigan
Hi Jonathan, On Fri, May 9, 2014 at 1:12 PM, Jonathan Nieder jrnie...@gmail.com wrote: Hi, Tim Henigan wrote: However, I like the idea of simply removing the directory from contrib and pointing to 'difftool --dir-diff' in the release notes. Thanks. I believe Junio uses commit messages

Re: [PATCH 1/5] difftool: Simplify print_tool_help()

2012-07-24 Thread Tim Henigan
On Sun, Jul 22, 2012 at 11:42 PM, David Aguilar dav...@gmail.com wrote: Eliminate a global variable and File::Find usage by building upon basename() and glob() instead. glob was used in an early revision of the patch that led to bf73fc2 (difftool: print list of valid tools with '--tool-help')

Re: [PATCH v3 4/5] difftool: Use symlinks when diffing against the worktree

2012-07-24 Thread Tim Henigan
I'm sorry I am so late to see and comment on this...I am just getting caught up after a few busy weeks due to $dayjob and vacation. On Mon, Jul 23, 2012 at 2:05 AM, David Aguilar dav...@gmail.com wrote: diff --git a/git-difftool.perl b/git-difftool.perl index 2ae344c..a5b371f 100755 ---