Re: [PATCH] strbuf: let strbuf_addftime handle %z and %Z itself

2017-06-12 Thread Ulrich Mueller
> On Mon, 12 Jun 2017, Ævar Arnfjörð Bjarmason wrote: > On Mon, Jun 12, 2017 at 5:12 PM, Junio C Hamano wrote: >> René Scharfe writes: >>> Yes, or you could look up a time zone name somewhere else -- except we >>> don't have a way to do that, at least for now. >> >> Is that only "for now"?

Re: [PATCH] strbuf: let strbuf_addftime handle %z and %Z itself

2017-06-13 Thread Ulrich Mueller
> On Tue, 13 Jun 2017, René Scharfe wrote: > Am 12.06.2017 um 21:02 schrieb Ævar Arnfjörð Bjarmason: >> Which gives me a pretty good idea of where the people who are making >> my colleges / collaborators who are making commits all over the world >> are located, for the purposes of reinforcing

Re: [PATCH v2] strbuf: let strbuf_addftime handle %z and %Z itself

2017-06-15 Thread Ulrich Mueller
> On Thu, 15 Jun 2017, René Scharfe wrote: > Callers can opt out for %Z by passing NULL as timezone name. %z is > always handled internally -- this helps on Windows, where strftime would > expand it to a timezone name (same as %Z), in violation of POSIX. > Modifiers are not handled, e.g. %Ez

git-2.13.0: log --date=format:%z not working

2017-05-26 Thread Ulrich Mueller
The following commands work as expected (using commit b06d364310 in the git://git.kernel.org/pub/scm/git/git.git repo as test case): $ export TZ=Europe/Berlin $ git --no-pager log -1 --pretty="%ad" --date=iso b06d364310 2017-05-09 23:26:02 +0900 $ git --no-pager log -1 --pretty="%ad" --date=iso-lo

Re: git-2.13.0: log --date=format:%z not working

2017-06-02 Thread Ulrich Mueller
> On Fri, 2 Jun 2017, Jeff King wrote: > On Fri, Jun 02, 2017 at 07:25:43PM +0200, René Scharfe wrote: >> On Linux "%z %Z" is expanded to "+0200 CEST" for me, while on Windows I >> get "Mitteleurop▒ische Sommerzeit Mitteleurop▒ische Sommerzeit". (That >> "▒" is probably supposed to be an "ä".

Re: git-2.13.0: log --date=format:%z not working

2017-06-02 Thread Ulrich Mueller
> On Fri, 2 Jun 2017, Jeff King wrote: > The remaining question is whether we want to care about preserving the > system %Z for the local-timezone case. No strong preference here. Maybe go for consistency, and have %Z always return the same format (either empty, or same as %z). That would at

Re: [PATCH] strbuf: let strbuf_addftime handle %z and %Z itself

2017-06-03 Thread Ulrich Mueller
> On Sat, 3 Jun 2017, René Scharfe wrote: > + case 'Z': > + strbuf_addstr(&munged_fmt, tz_name); Is it guaranteed that tz_name cannot contain a percent sign itself? Ulrich