[PATCH v2 03/11] i18n: add--interactive: mark strings with interpolation for translation

2016-06-29 Thread Vasco Almeida
Use of sprintf following die or error_msg is necessary for placeholder substitution take place. Signed-off-by: Vasco Almeida --- git-add--interactive.perl | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/git-add--interactive.perl b/git-add

[PATCH v2 00/11] Mark strings in perl script for translation

2016-06-29 Thread Vasco Almeida
Mark messages in some perl scripts for translation. Since v1, adds brackets so parameter grouping of sprintf parameters is easier to see. Interdiff included below. Vasco Almeida (11): i18n: add--interactive: mark strings for translation i18n: add--interactive: mark simple here documents for

[PATCH v2 04/11] i18n: add--interactive: mark plural strings

2016-06-29 Thread Vasco Almeida
Mark plural strings for translation. Unfold each action case in one entire sentence. Pass new keyword for xgettext to extract. Update test to include new subrotine Q__() for plural strings handling. Signed-off-by: Vasco Almeida --- Makefile | 3 ++- git-add

[PATCH v2 05/11] i18n: add--interactive: mark message for translation

2016-06-29 Thread Vasco Almeida
the correct entry of %patch_modes, focusing only on value of %patch_modes. Now, we are also interested in the key ('staged', 'stash', 'checkout_head', ...). Signed-off-by: Vasco Almeida --- git-add--interactive.perl | 91 ++-

[PATCH v2 02/11] i18n: add--interactive: mark simple here documents for translation

2016-06-29 Thread Vasco Almeida
se, reusing here document would add a trailer newline to the message, making them not match 100%, hence creating two entries in pot template for translation rather than a single entry. Signed-off-by: Vasco Almeida --- git-add--interactive.perl | 24 1 file changed, 12 i

[PATCH v2 01/11] i18n: add--interactive: mark strings for translation

2016-06-29 Thread Vasco Almeida
Mark simple strings (without interpolation) for translation. Brackets around first parameter of ternary operator is necessary because otherwise xgettext fails to extract strings marked for translation from the rest of the file. Signed-off-by: Vasco Almeida --- git-add--interactive.perl | 68

[PATCH v2 06/11] i18n: add--interactive: i18n of help_patch_cmd

2016-06-29 Thread Vasco Almeida
Mark help message of help_patch_cmd for translation. The message must be unfolded to be free of variables so we can have high quality translations. Signed-off-by: Vasco Almeida --- git-add--interactive.perl | 65 +++ 1 file changed, 54 insertions

Re: [PATCH] unpack-trees: fix English grammar in do-this-before-that messages

2016-06-24 Thread Vasco Almeida
Citando Junio C Hamano : Vasco Almeida writes: The only downside I can tell about this is translator are going to have to update those strings on their translations, but that is a normal thing to do on an active project like Git. A larger issue is this fails to update tests that check

Re: [PATCH] unpack-trees: fix English grammar in do-this-before-that messages

2016-06-24 Thread Vasco Almeida
Às 05:31 de 24-06-2016, Alex Henrie escreveu: > Signed-off-by: Alex Henrie > --- > unpack-trees.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/unpack-trees.c b/unpack-trees.c > index 6bc9512..11c37fb 100644 > --- a/unpack-trees.c > +++ b/unpack-tree

Re: [PATCH 11/11] i18n: difftool: mark warnings for translation

2016-06-22 Thread Vasco Almeida
A Terça, 21 de Junho de 2016 21:33:29 David Aguilar escreveu: > I'm assuming that the i18n infrastructure is prepared to deal > with perl's . dot syntax for string concatenation, though, and > I don't know whether that's true. Does that work? Yes, dot syntax does work. xgettext is able to extract

[PATCH 08/11] i18n: send-email: mark strings for translation

2016-06-21 Thread Vasco Almeida
Mark strings often displayed to user for translation. Signed-off-by: Vasco Almeida --- git-send-email.perl | 53 +++-- 1 file changed, 31 insertions(+), 22 deletions(-) diff --git a/git-send-email.perl b/git-send-email.perl index 6958785..2521832

[PATCH 01/11] i18n: add--interactive: mark strings for translation

2016-06-21 Thread Vasco Almeida
Mark simple strings (without interpolation) for translation. Brackets around first parameter of ternary operator is necessary because otherwise xgettext fails to extract strings marked for translation from the rest of the file. Signed-off-by: Vasco Almeida --- git-add--interactive.perl | 68

[PATCH 07/11] i18n: add--interactive: mark edit_hunk message for translation

2016-06-21 Thread Vasco Almeida
., wanting to change wording of one particular use case. Signed-off-by: Vasco Almeida --- git-add--interactive.perl | 60 ++- 1 file changed, 49 insertions(+), 11 deletions(-) diff --git a/git-add--interactive.perl b/git-add--interactive.perl ind

[PATCH 11/11] i18n: difftool: mark warnings for translation

2016-06-21 Thread Vasco Almeida
Signed-off-by: Vasco Almeida --- git-difftool.perl | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/git-difftool.perl b/git-difftool.perl index ebd13ba..fe7f003 100755 --- a/git-difftool.perl +++ b/git-difftool.perl @@ -22,6 +22,7 @@ use File::Path qw

[PATCH 10/11] i18n: send-email: mark string with interpolation for translation

2016-06-21 Thread Vasco Almeida
Mark warnings, errors and other messages that are interpolated for translation. We must call sprintf() before calling die() and in few other circumstances in order to interpolation take place. Signed-off-by: Vasco Almeida --- git-send-email.perl | 71

[PATCH 09/11] i18n: send-email: mark warnings and errors for translation

2016-06-21 Thread Vasco Almeida
Mark warnings, errors and other messages for translation. Signed-off-by: Vasco Almeida --- git-send-email.perl | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/git-send-email.perl b/git-send-email.perl index 2521832..e7f712e 100755 --- a

[PATCH 02/11] i18n: add--interactive: mark simple here documents for translation

2016-06-21 Thread Vasco Almeida
se, reusing here document would add a trailer newline to the message, making them not match 100%, hence creating two entries in pot template for translation rather than a single entry. Signed-off-by: Vasco Almeida --- git-add--interactive.perl | 24 1 file changed, 12 i

[PATCH 05/11] i18n: add--interactive: mark message for translation

2016-06-21 Thread Vasco Almeida
the correct entry of %patch_modes, focusing only on value of %patch_modes. Now, we are also interested in the key ('staged', 'stash', 'checkout_head', ...). Signed-off-by: Vasco Almeida --- git-add--interactive.perl | 112 +

[PATCH 04/11] i18n: add--interactive: mark plural strings

2016-06-21 Thread Vasco Almeida
Mark plural strings for translation. Unfold each action case in one entire sentence. Pass new keyword for xgettext to extract. Update test to include new subrotine Q__() for plural strings handling. Signed-off-by: Vasco Almeida --- Makefile | 3 ++- git-add

[PATCH 03/11] i18n: add--interactive: mark strings with interpolation for translation

2016-06-21 Thread Vasco Almeida
Use of sprintf following die or error_msg is necessary for placeholder substitution take place. Signed-off-by: Vasco Almeida --- git-add--interactive.perl | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/git-add--interactive.perl b/git-add

[PATCH 06/11] i18n: add--interactive: i18n of help_patch_cmd

2016-06-21 Thread Vasco Almeida
Mark help message of help_patch_cmd for translation. The message must be unfolded to be free of variables so we can have hight quality translations. Signed-off-by: Vasco Almeida --- git-add--interactive.perl | 65 +++ 1 file changed, 54 insertions

[PATCH v5 38/38] i18n: branch: mark comment when editing branch description for translation

2016-06-17 Thread Vasco Almeida
When one issues git branch --edit-description branch_name, a edit with that message commented out is opened. Mark that message for translation in to order to be localized. Signed-off-by: Vasco Almeida --- builtin/branch.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a

[PATCH v5 34/38] i18n: init-db: join message pieces

2016-06-17 Thread Vasco Almeida
used with test t0204-gettext-reencode-sanity.sh and not updating the translation would fail the test. Signed-off-by: Vasco Almeida --- builtin/init-db.c | 17 ++--- po/is.po | 46 -- 2 files changed, 38 insertions(+), 25 deletions(-)

[PATCH v5 36/38] i18n: submodule: escape shell variables inside eval_gettext

2016-06-17 Thread Vasco Almeida
-Scripts.html Signed-off-by: Vasco Almeida --- git-submodule.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/git-submodule.sh b/git-submodule.sh index f72b237..1ff2f3a 100755 --- a/git-submodule.sh +++ b/git-submodule.sh @@ -618,7 +618,7 @@ cmd_update

[PATCH v5 37/38] i18n: unmark die messages for translation

2016-06-17 Thread Vasco Almeida
These messages are relevant for the programmer only, not for the end user. Thus, they can be unmarked for translation, saving translator some work. Signed-off-by: Vasco Almeida --- git-bisect.sh | 2 +- wt-status.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/git

[PATCH v5 35/38] i18n: submodule: join strings marked for translation

2016-06-17 Thread Vasco Almeida
Join strings marked for translation since that would facilitate and improve translations result. Signed-off-by: Vasco Almeida --- git-submodule.sh | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/git-submodule.sh b/git-submodule.sh index 5b9674a..f72b237

[PATCH v5 32/38] i18n: remote: mark URL fallback text for translation

2016-06-17 Thread Vasco Almeida
Marks fallback text for translation that may be displayed in git remote show output. Signed-off-by: Vasco Almeida --- builtin/remote.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/builtin/remote.c b/builtin/remote.c index ae74da6..9f934cb 100644 --- a/builtin

[PATCH v5 27/38] i18n: config: unfold error messages marked for translation

2016-06-17 Thread Vasco Almeida
gibility and code conciseness are improved for that instance. Signed-off-by: Vasco Almeida --- cache.h| 9 - config.c | 101 - submodule-config.c | 2 +- 3 files changed, 94 insertions(+), 18 deletions(-) diff -

[PATCH v5 10/38] i18n: rebase: mark placeholder for translation

2016-06-17 Thread Vasco Almeida
Mark placeholder "" in git-rebase.sh for translation. The string containing the named placeholder is passed to shell function error_on_missing_default_upstream in git-parse-remote.sh which uses it to display a command hint for the user. Signed-off-by: Vasco Almeida --- git-rebase.sh

[PATCH v5 07/38] i18n: merge-octopus: mark messages for translation

2016-06-17 Thread Vasco Almeida
Mark messages in git-merge-octopus.sh for translation. Signed-off-by: Vasco Almeida --- git-merge-octopus.sh | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/git-merge-octopus.sh b/git-merge-octopus.sh index dc2fd1b..89e967a 100755 --- a/git-merge

[PATCH v5 21/38] t4153: fix negated test_i18ngrep call

2016-06-17 Thread Vasco Almeida
tests: fix negated test_i18ngrep calls", 2014-08-13). Signed-off-by: Vasco Almeida --- t/t4153-am-resume-override-opts.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t4153-am-resume-override-opts.sh b/t/t4153-am-resume-override-opts.sh index 7c013d8..8ea22d1 1007

[PATCH v5 13/38] i18n: git-sh-setup.sh: mark strings for translation

2016-06-17 Thread Vasco Almeida
, for instance, gettextln not being found. [1] http://www.gnu.org/software/gettext/manual/html_node/Preparing-Shell-Scripts.html Signed-off-by: Vasco Almeida --- Makefile | 4 +++- git-bisect.sh| 1 - git-merge-octopus.sh | 1 - git-rebase.sh| 1 - git-sh-setup.sh

[PATCH v5 16/38] i18n: rebase-interactive: mark comments of squash for translation

2016-06-17 Thread Vasco Almeida
ngettext instead of eval_gettext, since other languages have more complex plural forms. Signed-off-by: Vasco Almeida --- git-rebase--interactive.sh | 69 +- t/lib-rebase.sh| 1 + 2 files changed, 57 insertions(+), 13 deletions(-) diff --

[PATCH v5 15/38] i18n: rebase-interactive: mark here-doc strings for translation

2016-06-17 Thread Vasco Almeida
nce, under GETTEXT_POISON. Otherwise, tests would fail under GETTEXT_POISON, or other build that doesn't support the GNU gettext, because that function could not be found. Signed-off-by: Vasco Almeida --- git-rebase--interactive.sh| 30 +++--- git-sh-i18n.sh

[PATCH v5 19/38] tests: unpack-trees: update to use test_i18n* functions

2016-06-17 Thread Vasco Almeida
ot;i18n: unpack-trees: avoid substituting only a verb in sentences", 2016-05-12). Signed-off-by: Vasco Almeida --- t/t1011-read-tree-sparse-checkout.sh | 2 +- t/t3400-rebase.sh| 4 ++-- t/t3404-rebase-interactive.sh| 4 ++-- t/t7607-merge-overwrite.sh | 2

[PATCH v5 18/38] tests: use test_i18n* functions to suppress false positives

2016-06-17 Thread Vasco Almeida
marked for translation, suppressing false positives. Signed-off-by: Vasco Almeida --- t/t0008-ignores.sh| 4 ++-- t/t1300-repo-config.sh| 8 t/t1307-config-blob.sh| 5 + t/t1308-config-set.sh | 4 ++-- t/t1400-update-ref.sh

[PATCH v5 25/38] i18n: notes: mark strings for translation

2016-06-17 Thread Vasco Almeida
. Fix conflicts in %s and [...]". Signed-off-by: Vasco Almeida --- builtin/notes.c | 20 ++-- t/t3310-notes-merge-manual-resolve.sh | 8 t/t3320-notes-merge-worktrees.sh | 2 +- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git

[PATCH v5 33/38] i18n: remote: allow translations to reorder message

2016-06-17 Thread Vasco Almeida
Before this patch, translations couldn't place the branch name where it was better fit in the message "and with remote ". Allow translations that, instead of forcing the branch name to display right of the message. Signed-off-by: Vasco Almeida --- builtin/remote.c | 7 +++ 1

[PATCH v5 12/38] t6030: update to use test_i18ncmp

2016-06-17 Thread Vasco Almeida
Since the git bisect output tested here is subject to translation, the helper function test_i18ncmp should be used over test_cmp. Signed-off-by: Vasco Almeida --- t/t6030-bisect-porcelain.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t6030-bisect-porcelain.sh b/t

[PATCH v5 26/38] i18n: notes: mark options for translation

2016-06-17 Thread Vasco Almeida
Mark options description of git prune for translation. Signed-off-by: Vasco Almeida --- builtin/notes.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin/notes.c b/builtin/notes.c index d11e6eb..0572051 100644 --- a/builtin/notes.c +++ b/builtin/notes.c @@ -934,8

[PATCH v5 30/38] i18n: sequencer: add period to error message

2016-06-17 Thread Vasco Almeida
Add a period to error message so it matches others instances in sequencer.c. Now translator would have to translate such message only once. Signed-off-by: Vasco Almeida --- sequencer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sequencer.c b/sequencer.c index 57b3671

[PATCH v5 28/38] i18n: merge: mark messages for translation

2016-06-17 Thread Vasco Almeida
Mark messages shown to the user for translation. Signed-off-by: Vasco Almeida --- builtin/merge.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/builtin/merge.c b/builtin/merge.c index b555a1b..961def5 100644 --- a/builtin/merge.c +++ b/builtin/merge.c @@ -1014,7

[PATCH v5 17/38] i18n: setup: mark strings for translation

2016-06-17 Thread Vasco Almeida
Update tests that compare the strings newly marked for translation to succeed when running under GETTEXT_POISON. Signed-off-by: Vasco Almeida --- setup.c| 16 t/t1506-rev-parse-diagnosis.sh | 2 +- t/t4208-log-magic-pathspec.sh | 4 ++-- 3 files

[PATCH v5 14/38] i18n: rebase-interactive: mark strings for translation

2016-06-17 Thread Vasco Almeida
Mark strings in git-rebase--interactive.sh for translation. There is no need to source git-sh-i18n since git-rebase.sh already does so. Add git-rebase--interactive.sh to LOCALIZED_SH in Makefile in order to enable extracting strings marked for translation by xgettext. Signed-off-by: Vasco

[PATCH v5 31/38] i18n: standardise messages

2016-06-17 Thread Vasco Almeida
remove '%s'" "index file corrupt" "corrupt index file" "failed to read %s" "read of %s failed" "detach the HEAD at named commit" "detach HEAD at named commit" Signed-off-by: Vasco Almeida --- builtin/apply.c| 6 +++-

[PATCH v5 29/38] i18n: merge: change command option help to lowercase

2016-06-17 Thread Vasco Almeida
Change command option description to lowercase, matching pull counterpart option. Translators would have to translate such message only once. Signed-off-by: Vasco Almeida --- builtin/merge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/merge.c b/builtin/merge.c

[PATCH v5 11/38] i18n: bisect: simplify error message for i18n

2016-06-17 Thread Vasco Almeida
Internationalization from gettext manual [1]: "Simplify translatable strings so that they don't contain command substitution ("`...`" or "$(...)") [...]" [1] http://www.gnu.org/software/gettext/manual/html_node/Preparing-Shell-Scripts.html Signed-off-by: Vasco Almei

[PATCH v5 20/38] t9003: become resilient to GETTEXT_POISON

2016-06-17 Thread Vasco Almeida
The test t9003-help-autocorrect.sh fails when run under GETTEXT_POISON, because it's expecting to filter out the original output. Accommodate gettext poison case by also filtering out the default simulated output. Signed-off-by: Vasco Almeida --- t/t9003-help-autocorrect.sh | 4 ++-- 1

[PATCH v5 24/38] i18n: transport-helper.c: change N_() call to _()

2016-06-17 Thread Vasco Almeida
The N_() no-op call currently marks the string to be extracted by xgettext but doesn't trigger the retrieval of the translation at run time, whereas _() does both. Meaning that, in spite of having translations available, they were never retrieved to make use of them. Signed-off-by: Vasco Al

[PATCH v5 23/38] i18n: bisect: mark strings for translation

2016-06-17 Thread Vasco Almeida
In the last message, involving Q_(), try to mark the message in such way that is suited for RTL (Right to Left) languages. Update test t6030-bisect-porcelain.sh to reflect the changes. Signed-off-by: Vasco Almeida --- bisect.c| 56

[PATCH v5 22/38] t5523: use test_i18ngrep for negation

2016-06-17 Thread Vasco Almeida
of consistency and also to make obvious that those strings are subject to i18n. Signed-off-by: Vasco Almeida --- t/t5523-push-upstream.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/t/t5523-push-upstream.sh b/t/t5523-push-upstream.sh index 4a7b98b..d6981ba 100755

[PATCH v5 09/38] i18n: rebase: fix marked string to use eval_gettext variant

2016-06-17 Thread Vasco Almeida
The string message marked for translation should use eval_gettext variant instead of the gettext one, since we want to dollar-substitute $head_name in the result. Signed-off-by: Vasco Almeida --- git-rebase.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-rebase.sh b

[PATCH v5 02/38] i18n: advice: mark string about detached head for translation

2016-06-17 Thread Vasco Almeida
Mark string with advice seen by the user when in detached head. Update test t7201-co.sh to pass under GETTEXT_POISON build. Pretend success if the number of lines of "git checkout renamer^" output is not greater than 1 and test are running under GETTEXT_POISON. Signed-off-by: Vas

[PATCH v5 05/38] i18n: sequencer: mark entire sentences for translation

2016-06-17 Thread Vasco Almeida
ource code verbosity. Moreover, translators can now 1) translate the terms "revert" and "cherry-pick" if they please 2) have more leeway to adapt their translations. Signed-off-by: Vasco Almeida --- sequencer.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(

[PATCH v5 00/38] i18n and test updates

2016-06-17 Thread Vasco Almeida
duated to 'master'. Interdiff included below. Vasco Almeida (38): i18n: builtin/remote.c: fix mark for translation i18n: advice: mark string about detached head for translation i18n: advice: internationalize message for conflicts i18n: transport: mark strings for translation i1

[PATCH v5 06/38] i18n: sequencer: mark string for translation

2016-06-17 Thread Vasco Almeida
Mark informative string ": fast-forward" for translation. Signed-off-by: Vasco Almeida --- sequencer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sequencer.c b/sequencer.c index 88a7c78..57b3671 100644 --- a/sequencer.c +++ b/sequencer.c @@ -225,7 +225,7 @@

[PATCH v5 04/38] i18n: transport: mark strings for translation

2016-06-17 Thread Vasco Almeida
Mark one printf string and one error string for translation. Signed-off-by: Vasco Almeida --- transport.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/transport.c b/transport.c index 095e61f..59b911e 100644 --- a/transport.c +++ b/transport.c

[PATCH v5 03/38] i18n: advice: internationalize message for conflicts

2016-06-17 Thread Vasco Almeida
languages. Signed-off-by: Vasco Almeida --- advice.c| 17 +++-- builtin/pull.c | 2 +- t/t5520-pull.sh | 2 +- 3 files changed, 17 insertions(+), 4 deletions(-) diff --git a/advice.c b/advice.c index cb445a7..b84ae49 100644 --- a/advice.c +++ b/advice.c @@ -79,7 +79

[PATCH v5 08/38] merge-octupus: use die shell function from git-sh-setup.sh

2016-06-17 Thread Vasco Almeida
Source git-sh-setup in order to use die shell function from git-sh-setup.sh library instead of using the one defined in git-merge-octopus.sh. Remove the former die function. Signed-off-by: Vasco Almeida --- git-merge-octopus.sh | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff

[PATCH v5 01/38] i18n: builtin/remote.c: fix mark for translation

2016-06-17 Thread Vasco Almeida
The second string inside _() was not being extracted for translation by xgettext, meaning that, although the string was passed to gettext, there was no translation available. Mark each individual string instead of marking the result of ternary if. Signed-off-by: Vasco Almeida --- builtin

Re: What's cooking in git.git (Jun 2016, #05; Thu, 16)

2016-06-17 Thread Vasco Almeida
Junio C Hamano pobox.com> writes: > * va/i18n-even-more (2016-06-07) 38 commits > - i18n: branch: mark comment when editing branch description for translation > - i18n: unmark die messages for translation > - i18n: submodule: escape shell variables inside eval_gettext > - i18n: submodule: join

Re: [PATCH v4 34/38] i18n: init-db: join message pieces

2016-06-17 Thread Vasco Almeida
A Terça, 7 de Junho de 2016 12:55:37 Vasco Almeida escreveu: > Join message displayed during repository initialization in one entire > sentence. That would improve translations since it's easier translate an > entire sentence than translating each piece. > > Signed-o

[PATCH v4 34/38] i18n: init-db: join message pieces

2016-06-07 Thread Vasco Almeida
Join message displayed during repository initialization in one entire sentence. That would improve translations since it's easier translate an entire sentence than translating each piece. Signed-off-by: Vasco Almeida --- builtin/init-db.c | 17 ++--- 1 file changed, 10 inser

[PATCH v4 35/38] i18n: submodule: join strings marked for translation

2016-06-07 Thread Vasco Almeida
Join strings marked for translation since that would facilitate and improve translations result. Signed-off-by: Vasco Almeida --- git-submodule.sh | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/git-submodule.sh b/git-submodule.sh index 5b9674a..f72b237

[PATCH v4 38/38] i18n: branch: mark comment when editing branch description for translation

2016-06-07 Thread Vasco Almeida
When one issues git branch --edit-description branch_name, a edit with that message commented out is opened. Mark that message for translation in to order to be localized. Signed-off-by: Vasco Almeida --- builtin/branch.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a

[PATCH v4 37/38] i18n: unmark die messages for translation

2016-06-07 Thread Vasco Almeida
These messages are relevant for the programmer only, not for the end user. Thus, they can be unmarked for translation, saving translator some work. Signed-off-by: Vasco Almeida --- git-bisect.sh | 2 +- wt-status.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/git

[PATCH v4 36/38] i18n: submodule: escape shell variables inside eval_gettext

2016-06-07 Thread Vasco Almeida
-Scripts.html Signed-off-by: Vasco Almeida --- git-submodule.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/git-submodule.sh b/git-submodule.sh index f72b237..1ff2f3a 100755 --- a/git-submodule.sh +++ b/git-submodule.sh @@ -618,7 +618,7 @@ cmd_update

[PATCH v4 17/38] i18n: setup: mark strings for translation

2016-06-07 Thread Vasco Almeida
Update tests that compare the strings newly marked for translation to succeed when running under GETTEXT_POISON. Signed-off-by: Vasco Almeida --- setup.c| 16 t/t1506-rev-parse-diagnosis.sh | 2 +- t/t4208-log-magic-pathspec.sh | 4 ++-- 3 files

[PATCH v4 07/38] i18n: merge-octopus: mark messages for translation

2016-06-07 Thread Vasco Almeida
Mark messages in git-merge-octopus.sh for translation. Signed-off-by: Vasco Almeida --- git-merge-octopus.sh | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/git-merge-octopus.sh b/git-merge-octopus.sh index dc2fd1b..89e967a 100755 --- a/git-merge

[PATCH v4 04/38] i18n: transport: mark strings for translation

2016-06-07 Thread Vasco Almeida
Mark one printf string and one error string for translation. Signed-off-by: Vasco Almeida --- transport.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/transport.c b/transport.c index 095e61f..59b911e 100644 --- a/transport.c +++ b/transport.c

[PATCH v4 27/38] i18n: config: unfold error messages marked for translation

2016-06-07 Thread Vasco Almeida
gibility and code conciseness are improved for that instance. Signed-off-by: Vasco Almeida --- cache.h| 9 - config.c | 101 - submodule-config.c | 2 +- 3 files changed, 94 insertions(+), 18 deletions(-) diff -

[PATCH v4 18/38] tests: use test_i18n* functions to suppress false positives

2016-06-07 Thread Vasco Almeida
marked for translation, suppressing false positives. Signed-off-by: Vasco Almeida --- t/t0008-ignores.sh| 4 ++-- t/t1300-repo-config.sh| 8 t/t1307-config-blob.sh| 5 + t/t1308-config-set.sh | 4 ++-- t/t1400-update-ref.sh

[PATCH v4 32/38] i18n: remote: mark URL fallback text for translation

2016-06-07 Thread Vasco Almeida
Marks fallback text for translation that may be displayed in git remote show output. Signed-off-by: Vasco Almeida --- builtin/remote.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/builtin/remote.c b/builtin/remote.c index ae74da6..9f934cb 100644 --- a/builtin

[PATCH v4 09/38] i18n: rebase: fix marked string to use eval_gettext variant

2016-06-07 Thread Vasco Almeida
The string message marked for translation should use eval_gettext variant instead of the gettext one, since we want to dollar-substitute $head_name in the result. Signed-off-by: Vasco Almeida --- git-rebase.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-rebase.sh b

[PATCH v4 01/38] i18n: builtin/remote.c: fix mark for translation

2016-06-07 Thread Vasco Almeida
The second string inside _() was not being extracted for translation by xgettext, meaning that, although the string was passed to gettext, there was no translation available. Mark each individual string instead of marking the result of ternary if. Signed-off-by: Vasco Almeida --- builtin

[PATCH v4 25/38] i18n: notes: mark strings for translation

2016-06-07 Thread Vasco Almeida
. Fix conflicts in %s and [...]". Signed-off-by: Vasco Almeida --- builtin/notes.c | 20 ++-- t/t3310-notes-merge-manual-resolve.sh | 8 t/t3320-notes-merge-worktrees.sh | 2 +- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git

[PATCH v4 06/38] i18n: sequencer: mark string for translation

2016-06-07 Thread Vasco Almeida
Mark informative string ": fast-forward" for translation. Signed-off-by: Vasco Almeida --- sequencer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sequencer.c b/sequencer.c index 88a7c78..57b3671 100644 --- a/sequencer.c +++ b/sequencer.c @@ -225,7 +225,7 @@

[PATCH v4 24/38] i18n: transport-helper.c: change N_() call to _()

2016-06-07 Thread Vasco Almeida
The N_() no-op call currently marks the string to be extracted by xgettext but doesn't trigger the retrieval of the translation at run time, whereas _() does both. Meaning that, in spite of having translations available, they were never retrieved to make use of them. Signed-off-by: Vasco Al

[PATCH v4 02/38] i18n: advice: mark string about detached head for translation

2016-06-07 Thread Vasco Almeida
Mark string with advice seen by the user when in detached head. Update test t7201-co.sh to pass under GETTEXT_POISON build. Pretend success if the number of lines of "git checkout renamer^" output is not greater than 1 and test are running under GETTEXT_POISON. Signed-off-by: Vas

[PATCH v4 08/38] merge-octupus: use die shell function from git-sh-setup.sh

2016-06-07 Thread Vasco Almeida
Source git-sh-setup in order to use die shell function from git-sh-setup.sh library instead of using the one defined in git-merge-octopus.sh. Remove the former die function. Signed-off-by: Vasco Almeida --- git-merge-octopus.sh | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff

[PATCH v4 05/38] i18n: sequencer: mark entire sentences for translation

2016-06-07 Thread Vasco Almeida
ource code verbosity. Moreover, translators can now 1) translate the terms "revert" and "cherry-pick" if they please 2) have more leeway to adapt their translations. Signed-off-by: Vasco Almeida --- sequencer.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(

[PATCH v4 13/38] i18n: git-sh-setup.sh: mark strings for translation

2016-06-07 Thread Vasco Almeida
, for instance, gettextln not being found. [1] http://www.gnu.org/software/gettext/manual/html_node/Preparing-Shell-Scripts.html Signed-off-by: Vasco Almeida --- I don't know if we want to copy the text from git-sh-i18n.sh into git-sh-setup.sh file or sourcing the former in the latter is e

[PATCH v4 23/38] i18n: bisect: mark strings for translation

2016-06-07 Thread Vasco Almeida
In the last message, involving Q_(), try to mark the message in such way that is suited for RTL (Right to Left) languages. Update test t6030-bisect-porcelain.sh to reflect the changes. Signed-off-by: Vasco Almeida --- bisect.c| 56

[PATCH v4 15/38] i18n: rebase-interactive: mark here-doc strings for translation

2016-06-07 Thread Vasco Almeida
nce, under GETTEXT_POISON. Otherwise, tests would fail under GETTEXT_POISON, or other build that doesn't support the GNU gettext, because that function could not be found. Signed-off-by: Vasco Almeida --- git-rebase--interactive.sh| 30 +++--- git-sh-i18n.sh

[PATCH v4 20/38] t9003: become resilient to GETTEXT_POISON

2016-06-07 Thread Vasco Almeida
The test t9003-help-autocorrect.sh fails when run under GETTEXT_POISON, because it's expecting to filter out the original output. Accommodate gettext poison case by also filtering out the default simulated output. Signed-off-by: Vasco Almeida --- t/t9003-help-autocorrect.sh | 4 ++-- 1

[PATCH v4 14/38] i18n: rebase-interactive: mark strings for translation

2016-06-07 Thread Vasco Almeida
Mark strings in git-rebase--interactive.sh for translation. There is no need to source git-sh-i18n since git-rebase.sh already does so. Add git-rebase--interactive.sh to LOCALIZED_SH in Makefile in order to enable extracting strings marked for translation by xgettext. Signed-off-by: Vasco

[PATCH v4 21/38] t4153: fix negated test_i18ngrep call

2016-06-07 Thread Vasco Almeida
tests: fix negated test_i18ngrep calls", 2014-08-13). Signed-off-by: Vasco Almeida --- t/t4153-am-resume-override-opts.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t4153-am-resume-override-opts.sh b/t/t4153-am-resume-override-opts.sh index 7c013d8..8ea22d1 1007

[PATCH v4 33/38] i18n: remote: allow translations to reorder message

2016-06-07 Thread Vasco Almeida
Before this patch, translations couldn't place the branch name where it was better fit in the message "and with remote ". Allow translations that, instead of forcing the branch name to display right of the message. Signed-off-by: Vasco Almeida --- builtin/remote.c | 7 +++ 1

[PATCH v4 19/38] tests: unpack-trees: update to use test_i18n* functions

2016-06-07 Thread Vasco Almeida
ot;i18n: unpack-trees: avoid substituting only a verb in sentences", 2016-05-12). Signed-off-by: Vasco Almeida --- t/t1011-read-tree-sparse-checkout.sh | 2 +- t/t3400-rebase.sh| 4 ++-- t/t3404-rebase-interactive.sh| 4 ++-- t/t7607-merge-overwrite.sh | 2

[PATCH v4 28/38] i18n: merge: mark messages for translation

2016-06-07 Thread Vasco Almeida
Mark messages shown to the user for translation. Signed-off-by: Vasco Almeida --- builtin/merge.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/builtin/merge.c b/builtin/merge.c index b555a1b..961def5 100644 --- a/builtin/merge.c +++ b/builtin/merge.c @@ -1014,7

[PATCH v4 31/38] i18n: standardise messages

2016-06-07 Thread Vasco Almeida
remove '%s'" "index file corrupt" "corrupt index file" "failed to read %s" "read of %s failed" "detach the HEAD at named commit" "detach HEAD at named commit" Signed-off-by: Vasco Almeida --- builtin/apply.c| 6 +++-

[PATCH v4 16/38] i18n: rebase-interactive: mark comments of squash for translation

2016-06-07 Thread Vasco Almeida
ngettext instead of eval_gettext, since other languages have more complex plural forms. Signed-off-by: Vasco Almeida --- git-rebase--interactive.sh | 69 +- t/lib-rebase.sh| 1 + 2 files changed, 57 insertions(+), 13 deletions(-) diff --

[PATCH v4 10/38] i18n: rebase: mark placeholder for translation

2016-06-07 Thread Vasco Almeida
Mark placeholder "" in git-rebase.sh for translation. The string containing the named placeholder is passed to shell function error_on_missing_default_upstream in git-parse-remote.sh which uses it to display a command hint for the user. Signed-off-by: Vasco Almeida --- git-rebase.sh

[PATCH v4 12/38] t6030: update to use test_i18ncmp

2016-06-07 Thread Vasco Almeida
Since the git bisect output tested here is subject to translation, the helper function test_i18ncmp should be used over test_cmp. Signed-off-by: Vasco Almeida --- t/t6030-bisect-porcelain.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t6030-bisect-porcelain.sh b/t

[PATCH v4 26/38] i18n: notes: mark options for translation

2016-06-07 Thread Vasco Almeida
Mark options description of git prune for translation. Signed-off-by: Vasco Almeida --- builtin/notes.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin/notes.c b/builtin/notes.c index d11e6eb..0572051 100644 --- a/builtin/notes.c +++ b/builtin/notes.c @@ -934,8

[PATCH v4 22/38] t5523: use test_i18ngrep for negation

2016-06-07 Thread Vasco Almeida
of consistency and also to make obvious that those strings are subject to i18n. Signed-off-by: Vasco Almeida --- t/t5523-push-upstream.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/t/t5523-push-upstream.sh b/t/t5523-push-upstream.sh index 4a7b98b..d6981ba 100755

[PATCH v4 00/38] i18n and test updates

2016-06-07 Thread Vasco Almeida
d.gmane.org/gmane.comp.version-control.git/296106 Interdiff v3 v4 included bellow. Vasco Almeida (38): i18n: builtin/remote.c: fix mark for translation i18n: advice: mark string about detached head for translation i18n: advice: internationalize message for conflicts i18n: transport: mark

[PATCH v4 03/38] i18n: advice: internationalize message for conflicts

2016-06-07 Thread Vasco Almeida
languages. Signed-off-by: Vasco Almeida --- advice.c| 17 +++-- builtin/pull.c | 2 +- t/t5520-pull.sh | 2 +- 3 files changed, 17 insertions(+), 4 deletions(-) diff --git a/advice.c b/advice.c index cb445a7..b84ae49 100644 --- a/advice.c +++ b/advice.c @@ -79,7 +79

[PATCH v4 29/38] i18n: merge: change command option help to lowercase

2016-06-07 Thread Vasco Almeida
Change command option description to lowercase, matching pull counterpart option. Translators would have to translate such message only once. Signed-off-by: Vasco Almeida --- builtin/merge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/merge.c b/builtin/merge.c

[PATCH v4 30/38] i18n: sequencer: add period to error message

2016-06-07 Thread Vasco Almeida
Add a period to error message so it matches others instances in sequencer.c. Now translator would have to translate such message only once. Signed-off-by: Vasco Almeida --- sequencer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sequencer.c b/sequencer.c index 57b3671

<    1   2   3   4   5   >