Re: [PATCH] contrib/diff-highlight: multibyte characters diff

2014-02-13 Thread Yoshihiro Sugi
Thanks for reviewing. as you wrote, diff content may not be utf8 at all. and we don't know that the user's terminal watns is utf8. I think your trying utf8 decode and fall back approach is better than my patch, and do work well. is using $@ for catching error like the patch below? According to

[PATCH] contrib/diff-highlight: multibyte characters diff

2014-02-11 Thread Yoshihiro Sugi
Signed-off-by: Yoshihiro Sugi sugi1...@gmail.com diff-highlight split each hunks and compare them as byte sequences. it causes problems when diff hunks include multibyte characters. This change enable to work on such cases by decoding inputs and encoding output as utf8 string. --- contrib/diff