[PATCH v5] filter-branch: fix errors caused by refs that point at non-committish

2018-03-25 Thread Yuki Kokubun
lematic refs out early, before they are seen by the logic to see which refs have been modified and which have been left intact (which is where the unwanted error messages come from), and warn that these refs are left unwritten while doing so. Signed-off-by: Yuki Kokubun <orga.chem@gmail.com&g

Re: [PATCH v4] filter-branch: fix errors caused by refs that point at non-committish

2018-03-25 Thread Yuki Kokubun
References: <1521996898-7052-1-git-send-email-orga.chem@gmail.com> Content-Type: text/plain Sorry, I forgot add a line of "Reviewed-by". I'm gonna send the fixed patch again.

[PATCH v4] filter-branch: fix errors caused by refs that point at non-committish

2018-03-25 Thread Yuki Kokubun
lematic refs out early, before they are seen by the logic to see which refs have been modified and which have been left intact (which is where the unwanted error messages come from), and warn that these refs are left unwritten while doing so. Signed-off-by: Yuki Kokubun <orga.chem@gmail.com>

Re: [PATCH v3] filter-branch: fix errors caused by refs that point at non-committish

2018-03-25 Thread Yuki Kokubun
References: <5ab46520.0352650a.cc02b.a...@mx.google.com> <20180323050913.5188-1-orga.chem@gmail.com> Content-Type: text/plain > Grammo (third-person singular 'prints' misspelt

[PATCH v3] filter-branch: fix errors caused by refs that point at non-committish

2018-03-24 Thread Yuki Kokubun
"git filter-branch -- --all" print error messages when refs that point at objects that are not committish. Such refs can be created by "git replace" with trees or blobs. And also "git tag" with trees or blobs can create such refs. Filter these problematic refs out early, before they are seen by

Re: [PATCH] filter-branch: consider refs can refer to an object other than commit or tag

2018-03-24 Thread Yuki Kokubun
>> "git filter-branch -- --all" print unwanted error messages when refs that >> cannot be used with ^0 exist. > > It is not incorrect per-se, but if I were writing this, I'd say > "... when refs that point at objects that are not committish" or > something like that, as that is much closer to

[PATCH v2] filter-branch: fix errors caused by refs that cannot be used with ^0

2018-03-22 Thread Yuki Kokubun
"git filter-branch -- --all" print unwanted error messages when refs that cannot be used with ^0 exist. Such refs can be created by "git replace" with trees or blobs. Also, "git tag" with trees or blobs can create such refs. --- git-filter-branch.sh | 14 --

Re: [PATCH] filter-branch: consider refs can refer to an object other than commit or tag

2018-03-22 Thread Yuki Kokubun
> However, if we pre-filter to limit the refs in "$tempdir/heads" to > those that are committish (i.e. those that pass "$ref^0") like the > patch and subsequent discussion suggests, wouldn't we lose the > warning for these replace refs and non-committish tags. We perhaps > could do something

Re: [PATCH] filter-branch: consider refs can refer to an object other than commit or tag

2018-03-22 Thread Yuki Kokubun
> Yuki Kokubun <orga.chem@gmail.com> writes: > > >> Yuki Kokubun <orga.chem@gmail.com> writes: > >> > >> > "git filter-branch -- --all" can be confused when refs that refer to > >> > objects > &g

Re: [PATCH] filter-branch: consider refs can refer to an object other than commit or tag

2018-03-21 Thread Yuki Kokubun
> Yuki Kokubun <orga.chem@gmail.com> writes: > > > "git filter-branch -- --all" can be confused when refs that refer to objects > > other than commits or tags exists. > > Because "git rev-parse --all" that is internally used can return refs th

[PATCH] filter-branch: consider refs can refer to an object other than commit or tag

2018-03-21 Thread Yuki Kokubun
ting refs. Such refs can be created by "git replace" with objects other than commits or trees. Signed-off-by: Yuki Kokubun <orga.chem@gmail.com> --- This patch fix the bug of the first patch. The first patch did not consider tags. git-filter-branch.sh | 11 ++

[PATCH] filter-branch: consider refs/replace can refer to an object other than commit

2018-03-21 Thread Yuki Kokubun
refs can be created by "git replace" with objects other than commits. Signed-off-by: Yuki Kokubun <orga.chem@gmail.com> --- git-filter-branch.sh | 3 +++ t/t7003-filter-branch.sh | 13 + 2 files changed, 16 insertions(+) diff --git a/git-filter-branch.sh b/