lematic refs out early, before they are seen by the logic to
see which refs have been modified and which have been left intact (which is
where the unwanted error messages come from), and warn that these refs are left
unwritten while doing so.
Signed-off-by: Yuki Kokubun <orga.chem@gmail.com&g
References: <1521996898-7052-1-git-send-email-orga.chem@gmail.com>
Content-Type: text/plain
Sorry, I forgot add a line of "Reviewed-by".
I'm gonna send the fixed patch again.
lematic refs out early, before they are seen by the logic to
see which refs have been modified and which have been left intact (which is
where the unwanted error messages come from), and warn that these refs are left
unwritten while doing so.
Signed-off-by: Yuki Kokubun <orga.chem@gmail.com>
References:
<5ab46520.0352650a.cc02b.a...@mx.google.com>
<20180323050913.5188-1-orga.chem@gmail.com>
Content-Type: text/plain
> Grammo (third-person singular 'prints' misspelt
"git filter-branch -- --all" print error messages when refs that point at
objects that are not committish. Such refs can be created by "git replace" with
trees or blobs. And also "git tag" with trees or blobs can create such refs.
Filter these problematic refs out early, before they are seen by
>> "git filter-branch -- --all" print unwanted error messages when refs that
>> cannot be used with ^0 exist.
>
> It is not incorrect per-se, but if I were writing this, I'd say
> "... when refs that point at objects that are not committish" or
> something like that, as that is much closer to
"git filter-branch -- --all" print unwanted error messages when refs that
cannot be used with ^0 exist. Such refs can be created by "git replace" with
trees or blobs. Also, "git tag" with trees or blobs can create such refs.
---
git-filter-branch.sh | 14 --
> However, if we pre-filter to limit the refs in "$tempdir/heads" to
> those that are committish (i.e. those that pass "$ref^0") like the
> patch and subsequent discussion suggests, wouldn't we lose the
> warning for these replace refs and non-committish tags. We perhaps
> could do something
> Yuki Kokubun <orga.chem@gmail.com> writes:
>
> >> Yuki Kokubun <orga.chem@gmail.com> writes:
> >>
> >> > "git filter-branch -- --all" can be confused when refs that refer to
> >> > objects
> &g
> Yuki Kokubun <orga.chem@gmail.com> writes:
>
> > "git filter-branch -- --all" can be confused when refs that refer to objects
> > other than commits or tags exists.
> > Because "git rev-parse --all" that is internally used can return refs th
ting refs. Such refs can be created by "git replace" with
objects other than commits or trees.
Signed-off-by: Yuki Kokubun <orga.chem@gmail.com>
---
This patch fix the bug of the first patch.
The first patch did not consider tags.
git-filter-branch.sh | 11 ++
refs can be created by "git replace" with objects other than
commits.
Signed-off-by: Yuki Kokubun <orga.chem@gmail.com>
---
git-filter-branch.sh | 3 +++
t/t7003-filter-branch.sh | 13 +
2 files changed, 16 insertions(+)
diff --git a/git-filter-branch.sh b/
12 matches
Mail list logo