Re: [PATCH v5] worktree: add: introduce --checkout option

2016-03-29 Thread Zhang Lei
Thanks for the review. Sorry for the patch churn, I wasn't quite familiar with working with mailing list. 2016-03-30 3:20 GMT+08:00 Eric Sunshine : > On Tue, Mar 29, 2016 at 6:11 AM, Ray Zhang wrote: >> By adding this option which defaults to true,

Re: [PATCH v2] worktree: add: introduce --checkout option

2016-03-25 Thread Zhang Lei
users such option. 2016-03-25 19:41 GMT+08:00 Duy Nguyen <pclo...@gmail.com>: > On Fri, Mar 25, 2016 at 6:31 PM, Zhang Lei <zhanglei...@gmail.com> wrote: >> By the way, Duy, another unrelated question: why worktree name under >> .git/worktrees is being named >> after

Re: [PATCH v2] worktree: add: introduce --checkout option

2016-03-25 Thread Zhang Lei
Nguyen <pclo...@gmail.com>: > On Fri, Mar 25, 2016 at 8:29 AM, Eric Sunshine <sunsh...@sunshineco.com> > wrote: >> On Thu, Mar 24, 2016 at 9:22 PM, Eric Sunshine <sunsh...@sunshineco.com> >> wrote: >>> On Thu, Mar 24, 2016 at 5:52 AM, Zhang Lei <zhangle

Re: [PATCH v2] worktree: add: introduce --checkout option

2016-03-24 Thread Zhang Lei
hi Duy, My PATCH v1 did follow git-clone -n, however, Junio C Hamano and Eric Sunshine suggested that we should avoid doing so , as --no-no-checkout could be confusing. Yes, core.sparsecheckout is the global switch for all worktrees, but every worktree can have its own info/sparse-checkout.