[PATCH 1/1] Add the `p4-pre-submit` hook

The `p4-pre-submit` hook is executed before git-p4 submits code. If the hook exits with non-zero value, submit process won't start. Signed-off-by: Chen Bin --- Documentation/git-p4.txt | 8 Documentation/githooks.txt | 7 +++ git-p4.py | 16 ++

Re: [PATCH 1/1] Add the `p4-pre-submit` hook

I updated the patch. But for some reason the test keep failing at this line, `test_must_fail git p4 submit --dry-run >errs 2>&1 &&`. If I change this line to `test_must_fail git-p4 submit --dry-run >errs 2>&1 &&` the test will pass. Could you help me to resolve this issue? I'm really confused. I'

[PATCH 1/1] Add the `p4-pre-submit` hook

The `p4-pre-submit` hook is executed before git-p4 submits code. If the hook exits with non-zero value, submit process not start. Signed-off-by: Chen Bin --- Documentation/git-p4.txt | 8 Documentation/githooks.txt | 7 +++ git-p4.py | 16 +++- t

Re: [PATCH 1/1] add hook pre-p4-submit

`git-p4 rebase`. If unit test fails and he could not submit code, he would come to me for help. But I want to reduce my workload. Regards, Chen On Fri, Jul 27, 2018 at 7:09 AM, Luke Diamand wrote: > On 26 July 2018 at 10:21, Eric Sunshine wrote: >> On Wed, Jul 25, 2018 at 10:08 PM

[PATCH 1/1] add hook pre-p4-submit

Hook pre-p4-submit is executed before git-p4 actually submits code. If the hook exits with non-zero value, submit process will abort. Signed-off-by: Chen Bin --- Documentation/git-p4.txt | 12 Documentation/githooks.txt | 7 +++ git-p4.py | 21

Re: [PATCH 1/1] add hook pre-p4-submit

t; On Wed, Jul 25, 2018 at 9:45 AM Chen Bin wrote: >> Hook pre-p4-submit is executed before git-p4 actually submits code. >> If the hook exits with non-zero value, submit process will abort. > > Bikeshedding: Should this be named 'p4-pre-submit'? That way, if > git-p

[PATCH 1/1] add hook pre-p4-submit

Hook pre-p4-submit is executed before git-p4 actually submits code. If the hook exits with non-zero value, submit process will abort. Signed-off-by: Chen Bin --- Documentation/git-p4.txt | 7 +++ Documentation/githooks.txt | 7 +++ git-p4.py | 18

Re: [PATCH 1/1] add hook pre-p4-submit

Thanks for you review. I will update documentation asap. On Wed, Jul 25, 2018 at 7:14 PM, Ævar Arnfjörð Bjarmason wrote: > > On Wed, Jul 25 2018, Luke Diamand wrote: > >> On 23 July 2018 at 12:27, Chen Bin wrote: >>> Hook pre-p4-submit is executed before git-p4 actually

[PATCH 1/1] add hook pre-p4-submit

Hook pre-p4-submit is executed before git-p4 actually submits code. If the hook exits with non-zero value, submit process will abort. Signed-off-by: Chen Bin --- git-p4.py | 6 ++ t/t9800-git-p4-basic.sh | 22 ++ 2 files changed, 28 insertions(+) diff

Can `git grep` have `--Author` option?

This is a feature request. >From time to time, I want to re-use MY code. So git grep with --Author options >is really useful. My current git version is 2.6.3, looks it doesn't have this >option. -- Best Regards, Chen Bin -- Help me, help you -- To unsubscribe from this list: