Am Fr., 7. Dez. 2018 um 13:45 Uhr schrieb Eric Sunshine
:
>
> On Fri, Dec 7, 2018 at 7:36 AM Victor Toni wrote:
> > I'm wondering if there is any way to show which rules (ideally with
> > the .gitignore file they are coming from) are causing a specific file
> > to get i
In a rather complex setup with deep directory structure it happens
every now and then, that files get ignored when trying to add them.
As these files are _not_ shown in `git status` but in `git status
--ignored` so I guess the culprit is some misconfigured `.gitignore`.
Trying to ad the specific
On 19/09/2018 05:59, Duy Nguyen wrote:
> On Tue, Sep 18, 2018 at 6:13 AM Victor Engmark
> wrote:
[…]
>> $ cat > .gitignore << EOF
>>> *
>>> !foo bar
>>> !foo\ bar
>>> !"foo bar"
>
> No need to quote, either with double qu
$ cat > .gitignore << EOF
> */
> !foo\ bar/
> EOF
$ git status --short
?? .gitignore
?? foo bar/
I encountered this problem because Visual Studio Code creates a
configuration directory called "Code - OSS", and I exclude everything in
~/.config by default to avoid noise in `git status`.
$ git --version
git version 2.19.0
--
Kind regards
Victor Engmark
ate a patch
myself just to see that you already finished the patch.
Thanks a lot!
Best regards,
Victor
seems like a bug to me.
Do you have any suggestions how I could make this work?
Thank you,
Victor
Why half of Git output goes to stdout and half to stderr? I suspect
this is a bug.
Below I call `git pushbug` alias defined it the below presented config
file.
$ cat .git/config
[core]
repositoryformatversion = 0
filemode = true
bare = false
logallrefupdates =
I have three branches: master, prerelease, and devel.
Suppose now we are in master.
I often run the following command (in fact it is an alias, to save
typing):
git push && git checkout prerelease && git merge master && git push &&
git checkout devel && git merge prerelease && git push && git
> I am not sure if it is a good idea to show */*/* as an example in
> the message (that is an anti-example of 'one set of wildcard' by
> having three stars, isn't it?), but that is not a new issue this
> change introduces.
I agree, this should be changed, however I think this should be don
Introduce prefixed globs for branches and tags in git-svn.
Globs like 'release_*' allow users to avoid long lines in config like:
branches = branches/{release_20,release_21,release_22,...}
Signed-off-by: Victor Leschuk <vlesc...@accesssoftek.com>
---
Changes from v3:
* Wrapped al
Introduce prefixed globs for branches and tags in git-svn.
Globs like 'release_*' allow users to avoid long lines in config like:
branches = branches/{release_20,release_21,release_22,...}
Signed-off-by: Victor Leschuk <vlesc...@accesssoftek.com>
---
Changes from v1:
*
Introduce prefixed globs for branches and tags in git-svn.
Globs like 'release_*' allow users to avoid long lines in config like:
branches = branches/{release_20,release_21,release_22,...}
Signed-off-by: Victor Leschuk <vlesc...@accesssoftek.com>
---
Changes from v1 (in v2 I forgot to
ost things look fine with 1/2, comments
on 2/2 below...
Victor Leschuk <vlesc...@gmail.com> wrote:
Add test for git-svn prefixed globs.
Why a separate patch? Unless there's some documentation purpose
for a regression, usually tests and a feature should be added
atomically in the same commit.
Add test for git-svn prefixed globs.
Signed-off-by: Victor Leschuk <vlesc...@accesssoftek.com>
---
t/t9168-git-svn-prefixed-glob.sh | 136 +++
1 file changed, 136 insertions(+)
create mode 100755 t/t9168-git-svn-prefixed-glob.sh
diff --git a/t/t9168-g
Introduce prefixed globs for branches and tags in git-svn.
Signed-off-by: Victor Leschuk <vlesc...@accesssoftek.com>
---
Documentation/git-svn.txt | 5 +
perl/Git/SVN/GlobSpec.pm | 9 -
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/Documentation/git-svn
*
instead of this.
Thus I suggest to add support for such 'prefixed' globs into git-svn.
Victor Leschuk (2):
Introduce prefixed globs for branches and tags in git-svn.
Add test for git-svn prefixed globs.
Documentation/git-svn.txt| 5 ++
perl/Git/SVN/GlobSpec.pm | 9
"git grep" can now be configured (or told from the command line)
how many threads to use when searching in the working tree files.
Signed-off-by: Victor Leschuk <vlesc...@accesssoftek.com>
---
Documentation/config.txt | 4 +++
Documentation/git-grep.txt
Hello Junio,
On 12/15/2015 11:06 PM, Junio C Hamano wrote:
Victor Leschuk <vlesc...@gmail.com> writes:
Subject: Re: [PATCH 1/2] Introduce grep threads param
I'll retitle this to something like
grep: add --threads= option and grep.threads configuration
while queuing (which I did
ace (grep.threads
description in git-grep.txt) and is referenced from other places. Also made few
language improvements in documentation.
* Style improvements: splitted too long lines
Victor Leschuk (2):
"git grep" can now be configured (or told from the command line)
how many thread
threads can significantly
boost grep performance when working on slow filesystems (or repo isn't cached)
or through network (for example repo is located on NFS).
Signed-off-by: Victor Leschuk <vlesc...@accesssoftek.com>
---
builtin/grep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
gh network (for example repo is located on NFS).
Signed-off-by: Victor Leschuk <vlesc...@accesssoftek.com>
---
History of changes from the first version ($gmane/280053/:
* Param renamed from threads-num to threads
* Short version of '--threads' cmd key was removed
* Made num_t
Hello Eric:
Hmm, v7 doesn't seem to address any of the v6 review comments here[1].
Was that review merely overlooked or did you disagree with the
reviewer?
[1]: http://article.gmane.org/gmane.comp.version-control.git/281817
Sorry, it looks like I missed that letter. My bad.
History of
Hello all,
does anybody have time to review this patch?
PS Sorry for bothering =)
--
Best Regards,
Victor
From: Victor Leschuk [vlesc...@gmail.com]
Sent: Wednesday, November 11, 2015 03:52
To: git@vger.kernel.org
Cc: Victor Leschuk
Subject: [PATCH v6
tree files.
I haven't reviewed v6 yet. More eyes are welcome.
Actually v6 includes only changes to special meaning of "0" (0 is now
default behavior - 8 threads), little corrections to documentation and
getting rid of online_cpus() in decision-tree. All as discussed in
comments f
rged patch to pu?
Thanks.
--
Best Regards,
Victor
____
From: Victor Leschuk [vlesc...@gmail.com]
Sent: Wednesday, November 11, 2015 03:52
To: git@vger.kernel.org
Cc: Victor Leschuk
Subject: [PATCH v6] Add git-grep threads param
"git grep" can now be conf
8) threads will be used even on 1-core CPU.
Signed-off-by: Victor Leschuk <vlesc...@accesssoftek.com>
---
History of changes from the first version ($gmane/280053/:
* Param renamed from threads-num to threads
* Short version of '--threads' cmd key was removed
*
"git grep" can now be configured (or told from the command line)
how many threads to use when searching in the working tree files.
Signed-off-by: Victor Leschuk <vlesc...@accesssoftek.com>
---
Documentation/config.txt | 7 +
Documentation/git-grep.txt
tune up performance on
your machines. Leave it unset or set to "0" if you want to use default
number
(currently default number is 8 for all systems, however this behavior
can
be changed in future versions to better suite your hardware and
circumstances).
--
Victor
--
T
> if (list.nr || cached)
>num_threads = 1;
> if (!num_threads)
> num_threads = GREP_NUM_THREADS_DEFAULT;
> and then later, instead of use_threads, do:
> if (num_threads <= 1) {
... do single-threaded version ...
> } else {
... do multi-threaded version
On Mon, Nov 9, 2015 at 9:28 AM, Victor Leschuk
<vlesc...@accesssoftek.com> wrote:
>
> Maybe use the simplest version (and keep num_numbers == 0 also as flag for
> all other checks in code like if(num_flags) ):
>
> if (list.nr || cached )
> num_threads = 0; // d
no need to double check here */
die(_("Ivalid number of threads specified (%d)"), num_threads)
}
--
Victor
--
To unsubscribe from this list: send the line "unsubsc
After that we may focus (in future) on developing smarter heuristics for
parallelity-relationed params.
Also we should specify in documentation that number of your CPUs may not the
optimal value and customer should find his own best values based on other
circumstances.
Correct?
--
Victor--
T
From: Jeff King [p...@peff.net]
Sent: Tuesday, November 03, 2015 22:40
To: Junio C Hamano
Cc: Victor Leschuk; git@vger.kernel.org; Victor Leschuk;
torva...@linux-foundation.org; j...@keeping.me.uk
Subject: Re: [PATCH v4] Add git-grep threads param
On Tue
f customization can be useful in tuning up performance as
confirmed by conducted tests. And in most cases having anything hard-coded is
worse than giving users opportunity to change it, isn't it?
--
Best Regards,
Victor--
To unsubscribe from this list: send the line "unsubscribe git&q
Hello all,
do we have any objections on this patch?
--
Best Regards,
Victor
From: Victor Leschuk [vlesc...@gmail.com]
Sent: Tuesday, October 27, 2015 14:22
To: git@vger.kernel.org
Cc: Victor Leschuk
Subject: [PATCH v4] Add git-grep threads param
Make
; patch and submit it?
Hello Johannes,
Sure, I will prepare the patch as soon as this one is included in master.
--
Victor
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ect commit cd0b9ee2946d2df3626943347332a4d86f93b126-dirty
No segfault occured. I am using
git version 2.6.2.308.g3b8f10c
Could you please specify which version of git you are using and also try
to reproduce it with latest 2.6.2?
--
Victor
--
To unsubscribe from this list: send the line "
the alternate entry */
*alt_odb_tail = ent; /* <= alt_obd_tail is NULL here */
alt_odb_tail = &(ent->next);
ent->next = NULL;
Will try to take a closer look at it.
--
Victor
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to ma
is not in $PATH, set different debuggers (for example, I
usually use cgdb), or even set it to /path/to/gdb_wrapper.sh which could
contain different gdb options and tunings.
--
Victor
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majo
'{sum+=$1} END{printf "%.2f\n",
sum/ntests}'
done
Note: With hot-cache grepping with 4 threads gives fastest results on both
4-core and 8-core machines.
Thus I think it can be useful for users to be able to tune the threads number
according to their needs.
--
Victor--
To unsubscribe
Make number of git-grep worker threads a configuration parameter.
According to several tests on systems with different number of CPU cores
the hard-coded number of 8 threads is not optimal for all systems:
tuning this parameter can significantly speed up grep performance.
Signed-off-by: Victor
void *cb)
{
int st = grep_config(var, value, cb);
+ if (thread_config(var, value, cb) < 0)
+ st = -1;
if (git_color_default_config(var, value, cb) < 0)
st = -1;
return st;
What do you think?
--
Best Regards,
Victor
--
To unsubscribe from this
ssibly renaming it
> `num_threads`)?
This thought also crossed my mind, however we already pass grep_opt to
start_threads() function,
so I think passing it to wait_all() is not that ugly, and kind of symmetric.
And I do not like the idea
of duplicating same information in different places. What do
Make number of git-grep worker threads a configuration parameter.
According to several tests on systems with different number of CPU cores
the hard-coded number of 8 threads is not optimal for all systems:
tuning this parameter can significantly speed up grep performance.
Signed-off-by: Victor
ct dir_struct *dir, const
char *path, int len, const stru
int file_exists(const char *f)
{
struct stat sb;
+ if (!strcmp(f, ":/")) {
+ /* ":/" - root dir, always exists */
+ return 1;
+ }
return lstat(f, ) == 0;
my 4-core and 8-core systems the thread number of 4 worked about 20% faster
than
default 8. So I think it is better to allow users tune this parameter.
Signed-off-by: Victor Leschuk <vlesc...@accesssoftek.com>
---
Documentation/config.txt | 4
Documentation/git-grep.txt
Hello John,
I haven't noticed the --threads option in pack-objects, I will fix the patch to
make naming more uniform. Do you have any comments regarding the functionality?
--
Best Regards,
Victor
From: John Keeping [j...@keeping.me.uk]
Sent: Thursday
of 4 worked about 20% faster
than
default 8. So I think it is better to allow users tune this parameter.
Signed-off-by: Victor Leschuk <vlesc...@accesssoftek.com>
---
Documentation/config.txt | 4
Documentation/git-grep.txt | 5 +
builtin/
Hello Junio,
sorry that was my fault, I was building it wrong way (defined NO_PTHREADS in
CFLAGS variable, not as separate make variable). Sorry for the false alarm.
--
Best Regards,
Victor
From: Junio C Hamano [jch2...@gmail.com] On Behalf Of Junio C
Hello all,
I think that no one tried it for a long time but I needed a single-threaded git
version for debug purpose. I tried to build with -DNO_PTHREADS and
thread-utils.c failed to compile.
In brief the situation is the following:
in header file we have something like that:
#ifndef
git-cat-file.
Thanks also for the advice to use git gc config options, I tested gc.auto=0 and
it lead to the same behavior as my setting MALLOC_LIMIT, however it is more
correct way to get this effect =)
I agree that we shouldn't worry about mapped files.
--
Best Regards,
Victor
Version: 2.6.1-1
Am I missing something? The manual seems to be for the right version:
$ git help pull | tail -n1 | tr -s ' '
Git 2.6.1 10/06/2015 GIT-PULL(1)
I'm running the system installed Git:
$ type -a git
git is /usr/bin/git
Cheers
Victor
--
To unsubscribe from this list: send
r each
commit in perl code and just perform one large gc operation at the end. It will
cost disk space during clone but save us memory. What do you think?
As for your suggestion regarding periodic restart of batch process inside
git-cat-file, I think we could give
through the
documentation and didn't see why fast-import can't be used to sync an existing
repo after the import. Am I missing something?
Thanks in advance for clarification.
--
Best Regards,
Victor--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message
ing the existing convention. Do you think
we need to change it and stick with --catch-file-batch=1/--cat-file-batch=0 ?
--
Best Regards,
Victor
From: Victor Leschuk
Sent: Monday, September 21, 2015 3:03 PM
To: Junio C Hamano
Cc: git@vger.kernel.org
Subject:
Signed-off-by: Victor Leschuk <vlesc...@accesssoftek.com>
---
git-svn.perl | 1 +
perl/Git.pm | 41 -
2 files changed, 41 insertions(+), 1 deletion(-)
diff --git a/git-svn.perl b/git-svn.perl
index 36f7240..b793c26 100755
--- a/git-svn.perl
+++
really slowed down the process. So I
decided to suggest to make the batch mode optional to let the user "tune" the
process and created a patch for this.
As for your code-style notes, I agree with them, will adjust the code.
--
Best Regards,
Victor
__
se let me know your thoughts.
--
Best Regards,
Victor Leschuk
or speed up clone process... Correct me if I'm wrong.
Reposurgeon looks interesting... Will give it a try.
Btw, what do you think of getting rid of batch mode for clone/fetch in perl
code. It really hardly has any impact on performance but reduces memory usage a
lot.
--
Best Regards,
Victor
Hi,
I used below command to configure:
./configure --prefix=/usr/local/git-2.1.3/ --disable-pthreads
Actually, I think the error message is quite clear this time, it is about
hook of Deleting a tag is not allowed in this repository.
Can I try to disable the hook?
Thanks,
Victor
--
View
Hi,
I tried to install this version git on sparc 10, the git clone command can
be executed successfully.
So is there any specific issue about sparc 8 for git to make/install?
Anyway, I will try to install on sparc 8 again.
Thanks,
Victor
--
View this message in context:
http://git.661346
details, does anyone have any idea why this
happened?
Thanks very much!
Victor
(gdb) bt full
#0 0xff0332ec in strlen () from /usr/lib/libc.so.1
No symbol table info available.
#1 0xff0866b8 in _doprnt () from /usr/lib/libc.so.1
No symbol table info available.
#2 0xff088ac0 in vsnprintf () from
builtin/index-pack.o
type_cas_lock builtin/index-pack.o
ld: fatal: Symbol referencing errors. No output written to git
How can I overcome this?
Thanks,
Victor
--
View this message in context:
http://git.661346.n2.nabble.com/Installed-git-2-1-3-on-sparc-8-but-got-core-dump
\...
Thanks,
Victor
--
View this message in context:
http://git.661346.n2.nabble.com/Installed-git-2-1-3-on-sparc-8-but-got-core-dump-during-git-clone-tp7620692p7620694.html
Sent from the git mailing list archive at Nabble.com.
--
To unsubscribe from this list: send the line unsubscribe git
As you may know ReactOS is now working in the new ReactOS Community Edition.
It's a new OS, with new features, redesigned image, powered by the new ReactOS
kernel which boosts its compatibility with apps and drivers. You can see a
comparative, and the new site here:
show gpg signature (if any) for commit message in gitweb
in case of valid signature highlight it with green
in case of invalid signature highlight it with red
Signed-off-by: Victor Kartashov victor.kartas...@gmail.com
---
here's new patch
fixed remarks by Eric Sunshine
pop @commit_lines
On 28 March 2014 21:47, Junio C Hamano gits...@pobox.com wrote:
Teach gitweb to show GPG signature verification status when
showing a commit that is signed. Highlight in green or red to
differentiate valid and invalid signatures.
or something?
Yes, kind of :)
Is it a good
shows gpg signature (if any) for commit message in gitweb
in case of successfully verifying the signature highlights it with green
Signed-off-by: Victor Kartashov victor.kartas...@gmail.com
---
gitweb/gitweb.perl | 33 ++---
gitweb/static/gitweb.css | 5
68 matches
Mail list logo
