Re: $GIT_DIR is no longer set when pre-commit hooks are called

2018-08-28 Thread Johannes Schindelin
Hi Peff, On Mon, 27 Aug 2018, Jeff King wrote: > On Mon, Aug 27, 2018 at 06:25:26PM +0200, Johannes Schindelin wrote: > > > On Sat, 25 Aug 2018, Jeff King wrote: > > > > > On Wed, Aug 22, 2018 at 04:16:00PM -0700, Gregory Oschwald wrote: > > > > > > diff --git a/builtin/commit.c

Re: $GIT_DIR is no longer set when pre-commit hooks are called

2018-08-27 Thread Jeff King
On Mon, Aug 27, 2018 at 06:25:26PM +0200, Johannes Schindelin wrote: > On Sat, 25 Aug 2018, Jeff King wrote: > > > On Wed, Aug 22, 2018 at 04:16:00PM -0700, Gregory Oschwald wrote: > > > > diff --git a/builtin/commit.c b/builtin/commit.c > > index 3bfeabc463..3670024a25 100644 > > ---

Re: $GIT_DIR is no longer set when pre-commit hooks are called

2018-08-27 Thread Johannes Schindelin
Hi Peff, On Sat, 25 Aug 2018, Jeff King wrote: > On Wed, Aug 22, 2018 at 04:16:00PM -0700, Gregory Oschwald wrote: > > diff --git a/builtin/commit.c b/builtin/commit.c > index 3bfeabc463..3670024a25 100644 > --- a/builtin/commit.c > +++ b/builtin/commit.c > @@ -1440,6 +1440,7 @@ int

Re: $GIT_DIR is no longer set when pre-commit hooks are called

2018-08-25 Thread Jeff King
On Wed, Aug 22, 2018 at 04:16:00PM -0700, Gregory Oschwald wrote: > As of the release of 2.18.0, $GIT_DIR is no longer set before calling > pre-commit hooks. This change was introduced in "set_work_tree: use > chdir_notify" (8500e0de) and is still present in master. > > I reviewed the discussion

$GIT_DIR is no longer set when pre-commit hooks are called

2018-08-22 Thread Gregory Oschwald
As of the release of 2.18.0, $GIT_DIR is no longer set before calling pre-commit hooks. This change was introduced in "set_work_tree: use chdir_notify" (8500e0de) and is still present in master. I reviewed the discussion when this change was initially submitted, and I don't think this behavior