Re: %C(auto) not working as expected

On Tue, Oct 25, 2016 at 7:58 PM, Jeff King wrote: > On Tue, Oct 25, 2016 at 07:52:21PM +0700, Duy Nguyen wrote: > >> > Yeah, adding a "%C(enable-auto-color)" or something would be backwards >> > compatible and less painful than using "%C(auto)" everywhere. I do >> > wonder if

Re: %C(auto) not working as expected

On Tue, Oct 25, 2016 at 07:52:21PM +0700, Duy Nguyen wrote: > > Yeah, adding a "%C(enable-auto-color)" or something would be backwards > > compatible and less painful than using "%C(auto)" everywhere. I do > > wonder if anybody actually _wants_ the "always show color, even if > > --no-color"

Re: %C(auto) not working as expected

On Mon, Oct 10, 2016 at 9:28 PM, Jeff King wrote: > On Mon, Oct 10, 2016 at 04:26:18PM +0700, Duy Nguyen wrote: > >> > If we do a revamp of the pretty-formats to bring them more in line with >> > ref-filter (e.g., something like "%(color:red)") maybe that would be an >> >

Re: %C(auto) not working as expected

On Mon, Oct 10, 2016 at 10:52:47PM +0200, René Scharfe wrote: > > I like the intent here, though I found "Values, color" hard to parse (it > > was not immediately clear that you mean "the color paragraph of the > > Values section", as commas are already being used in that sentence for > > the

Re: %C(auto) not working as expected

Am 10.10.2016 um 01:46 schrieb Jeff King: >> diff --git a/Documentation/pretty-formats.txt >> b/Documentation/pretty-formats.txt >> index a942d57..89e3bc6 100644 >> --- a/Documentation/pretty-formats.txt >> +++ b/Documentation/pretty-formats.txt >> @@ -166,7 +166,8 @@ endif::git-rev-list[] >> -

Re: %C(auto) not working as expected

On Mon, Oct 10, 2016 at 04:26:18PM +0700, Duy Nguyen wrote: > > If we do a revamp of the pretty-formats to bring them more in line with > > ref-filter (e.g., something like "%(color:red)") maybe that would be an > > opportunity to make minor adjustments. Though, hmm, it looks like > >

Re: %C(auto) not working as expected

On Mon, Oct 10, 2016 at 6:46 AM, Jeff King wrote: > On Sun, Oct 09, 2016 at 03:24:17PM +0200, René Scharfe wrote: > >> Offering a way to enable terminal-detection for all color codes of a >> format would be useful, but using the existing "auto," prefix for that >> would be a

Re: %C(auto) not working as expected

On Sun, Oct 09, 2016 at 03:24:17PM +0200, René Scharfe wrote: > Offering a way to enable terminal-detection for all color codes of a > format would be useful, but using the existing "auto," prefix for that > would be a behaviour change that could surprise users. Yeah. In retrospect, it probably

Re: %C(auto) not working as expected

Am 09.10.2016 um 12:04 schrieb Tom Hale: > On 2016-10-09 13:47, René Scharfe wrote: > >> %Cgreen emits color codes unconditionally. %C(auto,green) would respect >> the config settings. > > Thanks, I've never seen the (,) syntax documented before! Both the prefix "auto," for terminal-detection

Re: %C(auto) not working as expected

On 2016-10-09 13:47, René Scharfe wrote: %Cgreen emits color codes unconditionally. %C(auto,green) would respect the config settings. Thanks, I've never seen the (,) syntax documented before! What's strange is that this works: %C(auto,green bold) but %C(auto,green,bold) does not. Also:

Re: %C(auto) not working as expected

Am 09.10.2016 um 07:43 schrieb Tom Hale: $ ~/repo/git/git --version git version 2.10.0.GIT The `git-log` man page says: `auto` alone (i.e. %C(auto)) will turn on auto coloring on the next placeholders until the color is switched again. In this example: http://i.imgur.com/y3yLxk7.png I turn

%C(auto) not working as expected

$ ~/repo/git/git --version git version 2.10.0.GIT The `git-log` man page says: `auto` alone (i.e. %C(auto)) will turn on auto coloring on the next placeholders until the color is switched again. In this example: http://i.imgur.com/y3yLxk7.png I turn on auto colouring for green, but it