Re: "./t0001-init.sh --valgrind" is broken

2016-03-03 Thread Johannes Sixt
Am 03.03.2016 um 13:09 schrieb Duy Nguyen: +the-other-Johannes who added valgrind support. On Thu, Mar 3, 2016 at 1:55 PM, Johannes Sixt wrote: 8< Subject: [PATCH] t0001: fix GIT_* environment variable check under --valgrind When a test case is run without

Re: "./t0001-init.sh --valgrind" is broken

2016-03-03 Thread Jeff King
On Thu, Mar 03, 2016 at 07:09:12PM +0700, Duy Nguyen wrote: > +the-other-Johannes who added valgrind support. > > On Thu, Mar 3, 2016 at 1:55 PM, Johannes Sixt wrote: > > 8< > > Subject: [PATCH] t0001: fix GIT_* environment variable check under > > --valgrind > > > >

Re: "./t0001-init.sh --valgrind" is broken

2016-03-03 Thread Junio C Hamano
Duy Nguyen writes: > On Thu, Mar 3, 2016 at 7:09 PM, Duy Nguyen wrote: >> But it's probably better that we inject valgrind command >> from inside bin-wrappers script, the same way we inject gdb, I think. > > For the best of both worlds, we should recreate

Re: "./t0001-init.sh --valgrind" is broken

2016-03-03 Thread Duy Nguyen
On Thu, Mar 3, 2016 at 7:09 PM, Duy Nguyen wrote: > But it's probably better that we inject valgrind command > from inside bin-wrappers script, the same way we inject gdb, I think. For the best of both worlds, we should recreate bin-wrappers in test-lib.sh (i.e. the valgrind

Re: "./t0001-init.sh --valgrind" is broken

2016-03-03 Thread Duy Nguyen
+the-other-Johannes who added valgrind support. On Thu, Mar 3, 2016 at 1:55 PM, Johannes Sixt wrote: > 8< > Subject: [PATCH] t0001: fix GIT_* environment variable check under --valgrind > > When a test case is run without --valgrind, the wrap-for-bin.sh > helper script

Re: "./t0001-init.sh --valgrind" is broken

2016-03-02 Thread Johannes Sixt
Am 03.03.2016 um 02:04 schrieb Duy Nguyen: > On Thu, Mar 3, 2016 at 7:07 AM, Christian Couder > wrote: >> Hi, >> >> It looks like commit 57ea7123c86771f47f34e7d92d1822d8b429897a (git.c: >> make sure we do not leak GIT_* to alias scripts, Dec 20 14:50:19 2015) >> broke

Re: "./t0001-init.sh --valgrind" is broken

2016-03-02 Thread Junio C Hamano
Duy Nguyen writes: > On Thu, Mar 3, 2016 at 7:07 AM, Christian Couder > wrote: >> Hi, >> >> It looks like commit 57ea7123c86771f47f34e7d92d1822d8b429897a (git.c: >> make sure we do not leak GIT_* to alias scripts, Dec 20 14:50:19 2015) >> broke

Re: "./t0001-init.sh --valgrind" is broken

2016-03-02 Thread Duy Nguyen
On Thu, Mar 3, 2016 at 7:07 AM, Christian Couder wrote: > Hi, > > It looks like commit 57ea7123c86771f47f34e7d92d1822d8b429897a (git.c: > make sure we do not leak GIT_* to alias scripts, Dec 20 14:50:19 2015) > broke "./t0001-init.sh --valgrind". Just wanted to

"./t0001-init.sh --valgrind" is broken

2016-03-02 Thread Christian Couder
Hi, It looks like commit 57ea7123c86771f47f34e7d92d1822d8b429897a (git.c: make sure we do not leak GIT_* to alias scripts, Dec 20 14:50:19 2015) broke "./t0001-init.sh --valgrind". I get: expecting success: ( env | sed -ne "/^GIT_/s/=.*//p" && echo