[BUG?] `config branch.autosetuprebase true` breaks `rev-parse --is-inside-work-tree`

2014-10-08 Thread Richard Hartmann
Dear all, I am not sure if this is an actual bug or just a corner case that's not worth to be fixed. This was not tested with HEAD or even 2.1.2, but 2.1.1. Notwithstanding if the setting is correct, shouldn't rev-parse be resilient enough to at least be able to tell if we're in a work tree? I

Re: [BUG?] `config branch.autosetuprebase true` breaks `rev-parse --is-inside-work-tree`

2014-10-08 Thread Junio C Hamano
Richard Hartmann richih.mailingl...@gmail.com writes: So this is not a real bug report, more of a is this intended this way? richih@titanium ~/git_test % git rev-parse --is-inside-work-tree error: Malformed value for branch.autosetuprebase fatal: bad config file line 8 in .git/config

Re: [BUG?] `config branch.autosetuprebase true` breaks `rev-parse --is-inside-work-tree`

2014-10-08 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: In config.c, git_default_branch_config() must be corrected to set git_branch_track and autorebase to BRANCH_TRACK_MALFORMED and AUTOREBASE_MALFORMED and the users of these two variables must be fixed to deal with the malformed in the configuration

Re: [BUG?] `config branch.autosetuprebase true` breaks `rev-parse --is-inside-work-tree`

2014-10-08 Thread Tanay Abhra
On 10/8/2014 11:05 PM, Junio C Hamano wrote: Richard Hartmann richih.mailingl...@gmail.com writes: So this is not a real bug report, more of a is this intended this way? richih@titanium ~/git_test % git rev-parse --is-inside-work-tree error: Malformed value for branch.autosetuprebase

Re: [BUG?] `config branch.autosetuprebase true` breaks `rev-parse --is-inside-work-tree`

2014-10-08 Thread brian m. carlson
On Wed, Oct 08, 2014 at 01:22:33PM +0200, Richard Hartmann wrote: Notwithstanding if the setting is correct, shouldn't rev-parse be resilient enough to at least be able to tell if we're in a work tree? I understand why `git status` and the like would need to parse the full config, but