[BUG] b9c8e7f2fb6e breaks git bisect visualize

2017-06-13 Thread Øyvind A . Holm
Commit b9c8e7f2fb6e ("prefix_ref_iterator: don't trim too much") breaks git bisect visualize, this reproduces the bug: $ git bisect start $ git bisect bad $ git bisect good HEAD^^ $ git bisect visualize fatal: BUG: attempt to trim too many characters $ Reverting b9c8e7f2fb6e makes gi

Re: [BUG] b9c8e7f2fb6e breaks git bisect visualize

2017-06-14 Thread Michael Haggerty
On 06/14/2017 02:06 AM, Øyvind A. Holm wrote: > Commit b9c8e7f2fb6e ("prefix_ref_iterator: don't trim too much") breaks > git bisect visualize, this reproduces the bug: > > $ git bisect start > $ git bisect bad > $ git bisect good HEAD^^ > $ git bisect visualize > fatal: BUG: attempt to

Re: [BUG] b9c8e7f2fb6e breaks git bisect visualize

2017-06-14 Thread Jeff King
On Wed, Jun 14, 2017 at 10:36:43AM +0200, Michael Haggerty wrote: > The code for `git log --bisect` is questionable. It calls > `for_each_ref_in_submodule()` with prefix "refs/bisect/bad", which is > the actual name (not a prefix) of the reference that it is interested > in. So the callback is cal