Re: [GSoC][PATCH] userdiff: add built-in pattern for golang

Le 28/02/2018 à 23:32, Junio C Hamano a écrit : > Eric Sunshine writes: > >> On Wed, Feb 28, 2018 at 5:17 PM, Alban Gruin wrote: >>> Yes, but I can split the line like that: >>> >>> % cat >baz.go<<\EOF >>> package baz >>> func baz(arg1

Re: [GSoC][PATCH] userdiff: add built-in pattern for golang

Eric Sunshine writes: > On Wed, Feb 28, 2018 at 5:17 PM, Alban Gruin wrote: >> Yes, but I can split the line like that: >> >> % cat >baz.go<<\EOF >> package baz >> func baz(arg1 int64, >> arg2 int64) { >> } >> EOF >>

Re: [GSoC][PATCH] userdiff: add built-in pattern for golang

On Wed, Feb 28, 2018 at 5:17 PM, Alban Gruin wrote: > Yes, but I can split the line like that: > > % cat >baz.go<<\EOF > package baz > func baz(arg1 int64, > arg2 int64) { > } > EOF > % go build baz.go > > This complies to the standard

Re: [GSoC][PATCH] userdiff: add built-in pattern for golang

Le 28/02/2018 à 23:00, Eric Sunshine a écrit : > On Wed, Feb 28, 2018 at 4:31 PM, Alban Gruin wrote: diff --git a/userdiff.c b/userdiff.c @@ -38,6 +38,15 @@ IPATTERN("fortran", +PATTERNS("golang", +/* Functions */ +"^[ \t]*(func[

Re: [GSoC][PATCH] userdiff: add built-in pattern for golang

On Wed, Feb 28, 2018 at 4:31 PM, Alban Gruin wrote: >>> diff --git a/userdiff.c b/userdiff.c >>> @@ -38,6 +38,15 @@ IPATTERN("fortran", >>> +PATTERNS("golang", >>> +/* Functions */ >>> +"^[ \t]*(func[ \t]*.*(\\{[ \t]*)?)\n" >> >> Why is the brace (and

Re: [GSoC][PATCH] userdiff: add built-in pattern for golang

>> diff --git a/userdiff.c b/userdiff.c >> @@ -38,6 +38,15 @@ IPATTERN("fortran", >> +PATTERNS("golang", >> +/* Functions */ >> +"^[ \t]*(func[ \t]*.*(\\{[ \t]*)?)\n" > > Why is the brace (and possible following whitespace) optional? > Considering that the language demands that

Re: [GSoC][PATCH] userdiff: add built-in pattern for golang

On Wed, Feb 28, 2018 at 12:29 PM, Alban Gruin wrote: > This adds xfuncname and word_regex patterns for golang, a quite > popular programming language. It also includes test cases for the > xfuncname regex (t4018) and an updated documentation. s/an // > The xfuncname regex

[GSoC][PATCH] userdiff: add built-in pattern for golang

This adds xfuncname and word_regex patterns for golang, a quite popular programming language. It also includes test cases for the xfuncname regex (t4018) and an updated documentation. The xfuncname regex finds functions, structs and interfaces. The word_regex pattern finds identifiers, integers,