Re: [GSoC][PATCH 3/3] rebase -i: rewrite checkout_onto() in C

Hi Phillip, Le 18/06/2018 à 18:09, Phillip Wood a écrit : >> +    if (get_oid(orig_head, )) >> +    die(_("%s: not a valid OID"), orig_head); > > If this code is going to live long-term in sequencer.c then it would be > better not to die, but return an error instead as it's part of libgit. >

Re: [GSoC][PATCH 3/3] rebase -i: rewrite checkout_onto() in C

Hi Alban On 18/06/18 14:18, Alban Gruin wrote: This rewrites checkout_onto() from shell to C. A new command (“checkout-onto”) is added to rebase--helper.c. The shell version is then stripped. Signed-off-by: Alban Gruin --- builtin/rebase--helper.c | 7 ++-

[GSoC][PATCH 3/3] rebase -i: rewrite checkout_onto() in C

This rewrites checkout_onto() from shell to C. A new command (“checkout-onto”) is added to rebase--helper.c. The shell version is then stripped. Signed-off-by: Alban Gruin --- builtin/rebase--helper.c | 7 ++- git-rebase--interactive.sh | 25 - sequencer.c