Re: [GSoC][PATCH v2 1/7] sequencer: make two functions and an enum from sequencer.c public

Hi Junio, Le 03/07/2018 à 22:20, Junio C Hamano a écrit : > Alban Gruin writes: > >> -enum check_level { >> -CHECK_IGNORE = 0, CHECK_WARN, CHECK_ERROR >> -}; >> - >> -static enum check_level get_missing_commit_check_level(void) >> +enum missing_commit_check_level get_missing_commit_check_lev

Re: [GSoC][PATCH v2 1/7] sequencer: make two functions and an enum from sequencer.c public

Alban Gruin writes: > -enum check_level { > - CHECK_IGNORE = 0, CHECK_WARN, CHECK_ERROR > -}; > - > -static enum check_level get_missing_commit_check_level(void) > +enum missing_commit_check_level get_missing_commit_check_level(void) The new name definitely is better than "check_level" in th

[GSoC][PATCH v2 1/7] sequencer: make two functions and an enum from sequencer.c public

This makes rebase_path_todo(), get_missing_commit_check_level() and the enum check_level accessible outside sequencer.c. check_level is renamed missing_commit_check_level, and its value names are prefixed by MISSING_COMMIT_ to avoid namespace pollution. This will be needed for the rewrite of appe