Re: [GSoC][PATCH v2 2/2] rebase--interactive: rewrite the edit-todo functionality in C

2018-06-14 Thread Elijah Newren
Hi Alban, On Thu, Jun 14, 2018 at 1:24 PM, Alban Gruin wrote: > Le 14/06/2018 à 22:14, Junio C Hamano a écrit : >> Alban Gruin writes: >> >>> diff --git a/builtin/rebase--helper.c b/builtin/rebase--helper.c >>> index ded5e291d..d2990b210 100644 >>> --- a/builtin/rebase--helper.c >>> +++

Re: [GSoC][PATCH v2 2/2] rebase--interactive: rewrite the edit-todo functionality in C

2018-06-14 Thread Alban Gruin
Hi Junio, Le 14/06/2018 à 22:14, Junio C Hamano a écrit : > Alban Gruin writes: > >> diff --git a/builtin/rebase--helper.c b/builtin/rebase--helper.c >> index ded5e291d..d2990b210 100644 >> --- a/builtin/rebase--helper.c >> +++ b/builtin/rebase--helper.c >> @@ -12,12 +12,12 @@ static const char

Re: [GSoC][PATCH v2 2/2] rebase--interactive: rewrite the edit-todo functionality in C

2018-06-14 Thread Junio C Hamano
Alban Gruin writes: > diff --git a/builtin/rebase--helper.c b/builtin/rebase--helper.c > index ded5e291d..d2990b210 100644 > --- a/builtin/rebase--helper.c > +++ b/builtin/rebase--helper.c > @@ -12,12 +12,12 @@ static const char * const builtin_rebase_helper_usage[] = > { > int

[GSoC][PATCH v2 2/2] rebase--interactive: rewrite the edit-todo functionality in C

2018-06-13 Thread Alban Gruin
This rewrites the edit-todo functionality from shell to C. To achieve that, a new command mode, `edit-todo`, is added, and the `write-edit-todo` flag is removed, as the shell script does not need to write the edit todo help message to the todo list anymore. The shell version is then stripped in