Re: [GSoC][PATCH v2 2/3] rebase -i: rewrite setup_reflog_action() in C

2018-06-21 Thread Johannes Schindelin
Hi Alban, On Tue, 19 Jun 2018, Alban Gruin wrote: > This rewrites setup_reflog_action() from shell to C. The new version is > called checkout_base_commit(). This sounds like a serious mistake. How is it that a function that sets up a reflog action all of a sudden checks out a base commit? But

[GSoC][PATCH v2 2/3] rebase -i: rewrite setup_reflog_action() in C

2018-06-19 Thread Alban Gruin
This rewrites setup_reflog_action() from shell to C. The new version is called checkout_base_commit(). A new command is added to rebase--helper.c, “checkout-base”, as such as a new flag, “verbose”, to avoid silencing the output of the checkout operation called by checkout_base_commit(). The shell