Re: [GSoC][PATCH v3] test: avoid pipes in git related commands for test

2018-03-21 Thread Eric Sunshine
On Wed, Mar 21, 2018 at 2:11 PM, Junio C Hamano wrote: > Pratik Karki writes: >> Avoid using pipes downstream of Git commands since the exit >> codes of commands upstream of pipes get swallowed, thus potentially hiding >> failure of those commands.

Re: [GSoC][PATCH v3] test: avoid pipes in git related commands for test

2018-03-21 Thread Eric Sunshine
On Wed, Mar 21, 2018 at 2:11 PM, Junio C Hamano wrote: > Pratik Karki writes: >> The changes in patch increased from v1 to v2 because I >> got excited to work in Git codebase and I tried to >> fix the exisiting problems as much as possible. >> Hence,

Re: [GSoC][PATCH v3] test: avoid pipes in git related commands for test

2018-03-21 Thread Junio C Hamano
Pratik Karki writes: > Thank you Eric, for the review. This is follow on patch[1]. > > The changes in patch increased from v1 to v2 because I > got excited to work in Git codebase and I tried to > fix the exisiting problems as much as possible. > Hence, the large number

[GSoC][PATCH v3] test: avoid pipes in git related commands for test

2018-03-21 Thread Pratik Karki
Thank you Eric, for the review. This is follow on patch[1]. The changes in patch increased from v1 to v2 because I got excited to work in Git codebase and I tried to fix the exisiting problems as much as possible. Hence, the large number of changes. >> test_cmp expect.two output.two >>