Re: [GSoC][PATCH v3 03/13] editor: add a function to launch the sequence editor

2018-07-10 Thread Junio C Hamano
For those reading from sidelines, this is unchanged from the previous round, and looking good. Alban Gruin writes: > +const char *git_sequence_editor(void) > { > - const char *editor = git_editor(); > + const char *editor = getenv("GIT_SEQUENCE_EDITOR"); > + > + if (!editor) > +

Re: [GSoC][PATCH v3 03/13] editor: add a function to launch the sequence editor

2018-07-10 Thread Alban Gruin
Le 10/07/2018 à 14:15, Alban Gruin a écrit : > As part of the rewrite of interactive rebase, the sequencer will need to > open the sequence editor to allow the user to edit the todo list. > Instead of duplicating the existing launch_editor() function, this > refactors it to a new function,

[GSoC][PATCH v3 03/13] editor: add a function to launch the sequence editor

2018-07-10 Thread Alban Gruin
As part of the rewrite of interactive rebase, the sequencer will need to open the sequence editor to allow the user to edit the todo list. Instead of duplicating the existing launch_editor() function, this refactors it to a new function, launch_specified_editor(), which takes the editor as a