Re: [GSoC][PATCH v4 3/4] credential-cache: use XDG_CACHE_HOME for socket

2017-03-16 Thread Jeff King
On Thu, Mar 16, 2017 at 09:20:29AM -0700, Junio C Hamano wrote: > static char *get_socket_path(void) > { > struct stat st; > char *path; > > path = expand_user_path("~/.git-credential-cache"); > if (path && !stat(path, &st) && S_ISDIR(st.st_mode))) { > free(p

Re: [GSoC][PATCH v4 3/4] credential-cache: use XDG_CACHE_HOME for socket

2017-03-16 Thread Junio C Hamano
Devin Lehmacher writes: > + If your home directory is on a network-mounted filesystem, you > + may need to change this to a local filesystem. You must specify > + an absolute path. Nicely explained. If a socket cannot be created in "~/.git-credential-cache", existing users would ha

[GSoC][PATCH v4 3/4] credential-cache: use XDG_CACHE_HOME for socket

2017-03-15 Thread Devin Lehmacher
Make git-credential-cache follow the XDG base path specification by default. This increases consistency with other applications and helps keep clutter out of users' home directories. Check the old socket location, ~/.git-credential-cache/, and use ~/.git-credential-cache/socket if that directory e