Re: [GSoC][PATCH v5] test: avoid pipes in git related commands for test

2018-03-30 Thread Junio C Hamano
Eric Sunshine writes: > On Tue, Mar 27, 2018 at 1:31 PM, Pratik Karki wrote: >> Avoid using pipes downstream of Git commands since the exit codes >> of commands upstream of pipes get swallowed, thus potentially >> hiding failure of those

Re: [GSoC][PATCH v5] test: avoid pipes in git related commands for test

2018-03-30 Thread Eric Sunshine
On Tue, Mar 27, 2018 at 1:31 PM, Pratik Karki wrote: > Avoid using pipes downstream of Git commands since the exit codes > of commands upstream of pipes get swallowed, thus potentially > hiding failure of those commands. Instead, capture Git command > output to a file and

[GSoC][PATCH v5] test: avoid pipes in git related commands for test

2018-03-27 Thread Pratik Karki
Thank you Eric, I made changes according to your review. Cheers, Pratik -- >8 -- Avoid using pipes downstream of Git commands since the exit codes of commands upstream of pipes get swallowed, thus potentially hiding failure of those commands. Instead, capture Git command output to a file and