Re: [GSoC][PATCH v6 18/20] rebase--interactive2: rewrite the submodes of interactive rebase in C

Hi Junio, On Wed, 22 Aug 2018, Junio C Hamano wrote: > Johannes Schindelin writes: > > > I made this same mistake over and over again, myself. For some reason, > > John Keeping decided to use the singular form "revision" in 1e0dacdbdb75 > > (rebase: omit patch-identical commits with

Re: [GSoC][PATCH v6 18/20] rebase--interactive2: rewrite the submodes of interactive rebase in C

Johannes Schindelin writes: > I made this same mistake over and over again, myself. For some reason, > John Keeping decided to use the singular form "revision" in 1e0dacdbdb75 > (rebase: omit patch-identical commits with --fork-point, 2014-07-16), not > the plural. Perhaps we should give a

Re: [GSoC][PATCH v6 18/20] rebase--interactive2: rewrite the submodes of interactive rebase in C

Hi Alban, thank you for your tireless work on this! One thing that needs to be fixed, though: On Fri, 10 Aug 2018, Alban Gruin wrote: > +run_interactive () { > + GIT_CHERRY_PICK_HELP="$resolvemsg" > + export GIT_CHERRY_PICK_HELP > + > + test -n "$keep_empty" &&

[GSoC][PATCH v6 18/20] rebase--interactive2: rewrite the submodes of interactive rebase in C

This rewrites the submodes of interactive rebase (`--continue`, `--skip`, `--edit-todo`, and `--show-current-patch`) in C. git-rebase.sh is then modified to call directly git-rebase--interactive2 instead of git-rebase--interactive.sh. Signed-off-by: Alban Gruin --- No changes since v5.