Re: [GSoC][PATCH v7 05/26] stash: convert apply to builtin

2018-08-18 Thread Duy Nguyen
On Wed, Aug 8, 2018 at 9:00 PM Paul-Sebastian Ungureanu wrote: > + strbuf_init(>revision, 0); > + if (!commit) { > + if (!ref_exists(ref_stash)) { > + free_stash_info(info); > + fprintf_ln(stderr, "No stash entries found.");

Re: [GSoC][PATCH v7 05/26] stash: convert apply to builtin

2018-08-10 Thread Paul-Sebastian Ungureanu
Hellom On 10.08.2018 00:00, Junio C Hamano wrote: Paul-Sebastian Ungureanu writes: Good to see that the right way to forward a patch from another person is used, but is this a GSoC project? Yes, it is. I forgot to add the [GSoC] tag in the last series of patches. The reason I asked was

Re: [GSoC][PATCH v7 05/26] stash: convert apply to builtin

2018-08-09 Thread Junio C Hamano
Paul-Sebastian Ungureanu writes: >> Good to see that the right way to forward a patch from another >> person is used, but is this a GSoC project? > > Yes, it is. I forgot to add the [GSoC] tag in the last series of patches. The reason I asked was because IIRC GSoC was not supposed to be team

Re: [GSoC][PATCH v7 05/26] stash: convert apply to builtin

2018-08-09 Thread Paul-Sebastian Ungureanu
Hello, On 08.08.2018 23:18, Junio C Hamano wrote: Paul-Sebastian Ungureanu writes: From: Joel Teichroeb Add a builtin helper for performing stash commands. Converting all at once proved hard to review, so starting with just apply lets conversion get started without the other commands being

Re: [GSoC][PATCH v7 05/26] stash: convert apply to builtin

2018-08-08 Thread Junio C Hamano
Paul-Sebastian Ungureanu writes: > From: Joel Teichroeb > > Add a builtin helper for performing stash commands. Converting > all at once proved hard to review, so starting with just apply > lets conversion get started without the other commands being > finished. > > The helper is being

[GSoC][PATCH v7 05/26] stash: convert apply to builtin

2018-08-08 Thread Paul-Sebastian Ungureanu
From: Joel Teichroeb Add a builtin helper for performing stash commands. Converting all at once proved hard to review, so starting with just apply lets conversion get started without the other commands being finished. The helper is being implemented as a drop in replacement for stash so that