Re: [GSoC][PATCH v7 10/26] stash: convert show to builtin

2018-08-18 Thread Paul Sebastian Ungureanu
On Wed, Aug 15, 2018 at 11:20 PM, Thomas Gummerer wrote: > '--quiet' doesn't make too much sense to use with 'git stash show', so > I'm not sure whether or not it makes sense to support it at all. But > we do promise to pass all options through to in our documentation, so > the new behaviour is

Re: [GSoC][PATCH v7 10/26] stash: convert show to builtin

2018-08-15 Thread Thomas Gummerer
On 08/08, Paul-Sebastian Ungureanu wrote: > Add stash show to the helper and delete the show_stash, have_stash, > assert_stash_like, is_stash_like and parse_flags_and_rev functions > from the shell script now that they are no longer needed. > > Before this commit, `git stash show` would ignore

[GSoC][PATCH v7 10/26] stash: convert show to builtin

2018-08-08 Thread Paul-Sebastian Ungureanu
Add stash show to the helper and delete the show_stash, have_stash, assert_stash_like, is_stash_like and parse_flags_and_rev functions from the shell script now that they are no longer needed. Before this commit, `git stash show` would ignore `--index` and `--quiet` options. Now, `git stash show`