Re: [GSoC] [PATCH] travis-ci: added clang static analysis

2018-04-02 Thread Siddhartha Mishra
On Sun, Apr 1, 2018, 8:10 PM Lars Schneider wrote: > > That's a good summary and I don't see a better solution. While (3) > sounds nice, I think (2) is the fastest/most pragmatic solution. > > We already use the Travis cache [1]. You could use that mechanism to > store

Re: [GSoC] [PATCH] travis-ci: added clang static analysis

2018-04-01 Thread Lars Schneider
> On 13 Mar 2018, at 18:45, Siddhartha Mishra wrote: > > On Mon, Mar 12, 2018 at 3:49 PM, Lars Schneider > wrote: >> Hi, >> >> That looks interesting but I agree with Dscho that we should not limit >> this to master/maint. >> >> I assume you did

Re: [GSoC] [PATCH] travis-ci: added clang static analysis

2018-03-13 Thread Siddhartha Mishra
I'm extremely sorry, I forgot to attach my travis-ci job build with my previous message. Here it is : https://travis-ci.org/SiddharthaMishra/git/jobs/349478746#L1204. I also apologize for not trimming the email properly in the previous message. Sorry for the inconvenience, Siddhartha

Re: [GSoC] [PATCH] travis-ci: added clang static analysis

2018-03-13 Thread Siddhartha Mishra
On Mon, Mar 12, 2018 at 3:49 PM, Lars Schneider wrote: > Hi, > > That looks interesting but I agree with Dscho that we should not limit > this to master/maint. > > I assume you did run this on TravisCI already? Can you share a link? > I assume you did find errors? Can we

Re: [GSoC] [PATCH] travis-ci: added clang static analysis

2018-03-12 Thread Lars Schneider
Hi, That looks interesting but I agree with Dscho that we should not limit this to master/maint. I assume you did run this on TravisCI already? Can you share a link? I assume you did find errors? Can we fix them or are there too many? If there are existing errors, how do we define a "successful"

Re: [GSoC] [PATCH] travis-ci: added clang static analysis

2018-03-07 Thread Johannes Schindelin
Hi, On Tue, 6 Mar 2018, Siddhartha Mishra wrote: > Are there any other glaring issues you see in the code? The rest looks good to me! Ciao, Johannes

Re: [GSoC] [PATCH] travis-ci: added clang static analysis

2018-03-06 Thread Siddhartha Mishra
On Tue, Mar 6, 2018 at 6:57 AM, Junio C Hamano wrote: > SiddharthaMishra writes: > >> Added a job to run clang static code analysis on the master and maint branch >> >> Signed-off-by: SiddharthaMishra >> --- > > Why on 'master' and

Re: [GSoC] [PATCH] travis-ci: added clang static analysis

2018-03-05 Thread Junio C Hamano
SiddharthaMishra writes: > Added a job to run clang static code analysis on the master and maint branch > > Signed-off-by: SiddharthaMishra > --- Why on 'master' and 'maint' and not others? Quite frankly, I find this choice of branches rather odd, as

[GSoC] [PATCH] travis-ci: added clang static analysis

2018-03-05 Thread SiddharthaMishra
Added a job to run clang static code analysis on the master and maint branch Signed-off-by: SiddharthaMishra --- .travis.yml | 17 - ci/run-static-analysis.sh | 9 - 2 files changed, 24 insertions(+), 2 deletions(-) diff --git