Re: [GSoC] Move ~/.git-credential-cache to ~/.cache/git

2017-03-10 Thread Junio C Hamano
Devin Lehmacher writes: > If I’m not mistaken magit won’t stop working with the changed > location since it will just spawn an new instance of the > daemon. The only downside would be it wouldn’t get credentials > that were cached in the default socket. I am not quite sure

Re: [GSoC] Move ~/.git-credential-cache to ~/.cache/git

2017-03-10 Thread Devin Lehmacher
If I’m not mistaken magit won’t stop working with the changed location since it will just spawn an new instance of the daemon. The only downside would be it wouldn’t get credentials that were cached in the default socket. I am going to move forward with git-credential-cache just using the new

Re: [GSoC] Move ~/.git-credential-cache to ~/.cache/git

2017-03-10 Thread Noam Postavsky
On Fri, Mar 10, 2017 at 7:26 PM, Jonathan Nieder wrote: > I find that magit does rely on the socket path. > > Start credential daemon on magit-credential-hook > > If we let git start the daemon, Emacs will send a SIGHUP when git > finishes and closes the pty,

Re: [GSoC] Move ~/.git-credential-cache to ~/.cache/git

2017-03-10 Thread Jonathan Nieder
(+cc: npostavs) Hi Devin, Devin Lehmacher wrote: > I started working on this microproject and am not quite sure what is > necessary for backwards compatibility. Since the socket is recreated > whenever the credential daemon exits backwards compatibility > shouldn’t really be a concern with

[GSoC] Move ~/.git-credential-cache to ~/.cache/git

2017-03-10 Thread Devin Lehmacher
I started working on this microproject and am not quite sure what is necessary for backwards compatibility. Since the socket is recreated whenever the credential daemon exits backwards compatibility shouldn’t really be a concern with regard to where the socket is located in the filesystem.