Re: [PATCH/GSoC] add a add.patch config variable

2016-03-25 Thread Christian Couder
On Thu, Mar 24, 2016 at 10:09 PM, XZS wrote: > > diff --git a/t/t3701-add-interactive.sh b/t/t3701-add-interactive.sh > index deae948..25e4b2e 100755 > --- a/t/t3701-add-interactive.sh > +++ b/t/t3701-add-interactive.sh > @@ -380,4 +380,13 @@ test_expect_success 'patch mode

Re: [PATCH/GSoC] add a add.patch config variable

2016-03-25 Thread Junio C Hamano
Dominik Fischer writes: > As the configuration variable can be overwritten by a command line > option, I am tempted to amend this by replacing all occurrences of > "git add" in other scripts with "git add --no-patch" to ensure the > expected behavior. Don't even think about

Re: [PATCH/GSoC] add a add.patch config variable

2016-03-24 Thread Dominik Fischer
Am 24.03.2016 um 22:20 schrieb Junio C Hamano: XZS writes: Users may like to review their changes when staging by default. It is also a convenient safety feature for beginners nudging them to have a second look at their changes when composing a commit. To this end, the

Re: [PATCH/GSoC] add a add.patch config variable

2016-03-24 Thread Junio C Hamano
XZS writes: > Users may like to review their changes when staging by default. It is > also a convenient safety feature for beginners nudging them to have a > second look at their changes when composing a commit. > > To this end, the config variable allows to have git-add to

[PATCH/GSoC] add a add.patch config variable

2016-03-24 Thread XZS
Users may like to review their changes when staging by default. It is also a convenient safety feature for beginners nudging them to have a second look at their changes when composing a commit. To this end, the config variable allows to have git-add to always act like -p was passed.