Re: [PATCH/RFC/BUG] unpack-trees.c: do not use "the_index"

2018-06-04 Thread Brandon Williams
On 06/02, Elijah Newren wrote: > On Fri, Jun 1, 2018 at 10:03 PM, Duy Nguyen wrote: > > On Fri, Jun 1, 2018 at 8:34 PM, Elijah Newren wrote: > >> On Fri, Jun 1, 2018 at 9:11 AM, Nguyễn Thái Ngọc Duy > >> wrote: > >>> This is more of a bug report than an actual fix because I'm not sure > >>> if

Re: [PATCH/RFC/BUG] unpack-trees.c: do not use "the_index"

2018-06-02 Thread Elijah Newren
On Fri, Jun 1, 2018 at 10:03 PM, Duy Nguyen wrote: > On Fri, Jun 1, 2018 at 8:34 PM, Elijah Newren wrote: >> On Fri, Jun 1, 2018 at 9:11 AM, Nguyễn Thái Ngọc Duy >> wrote: >>> This is more of a bug report than an actual fix because I'm not sure >>> if "o->src_index" is always the correct

Re: [PATCH/RFC/BUG] unpack-trees.c: do not use "the_index"

2018-06-01 Thread Duy Nguyen
On Fri, Jun 1, 2018 at 8:34 PM, Elijah Newren wrote: > Hi, > > On Fri, Jun 1, 2018 at 9:11 AM, Nguyễn Thái Ngọc Duy > wrote: >> unpack-trees code works on multiple indexes specified in >> unpack_trees_options. Although they normally all refer to the_index at >> the call site, that is the

Re: [PATCH/RFC/BUG] unpack-trees.c: do not use "the_index"

2018-06-01 Thread Duy Nguyen
On Fri, Jun 1, 2018 at 8:51 PM, Stefan Beller wrote: > On Fri, Jun 1, 2018 at 11:34 AM, Elijah Newren wrote: > >>> +/* Do not use the_index here, you probably want o->src_index */ >>> +#define the_index the_index_should_not_be_used here >> >> Good call. > > Is the space instead of the underscore

Re: [PATCH/RFC/BUG] unpack-trees.c: do not use "the_index"

2018-06-01 Thread Stefan Beller
On Fri, Jun 1, 2018 at 11:34 AM, Elijah Newren wrote: >> +/* Do not use the_index here, you probably want o->src_index */ >> +#define the_index the_index_should_not_be_used here > > Good call. Is the space instead of the underscore between the last two words intentional?

Re: [PATCH/RFC/BUG] unpack-trees.c: do not use "the_index"

2018-06-01 Thread Elijah Newren
Hi, On Fri, Jun 1, 2018 at 9:11 AM, Nguyễn Thái Ngọc Duy wrote: > unpack-trees code works on multiple indexes specified in > unpack_trees_options. Although they normally all refer to the_index at > the call site, that is the caller's business. unpack-trees.c should > not make any assumption

[PATCH/RFC/BUG] unpack-trees.c: do not use "the_index"

2018-06-01 Thread Nguyễn Thái Ngọc Duy
unpack-trees code works on multiple indexes specified in unpack_trees_options. Although they normally all refer to the_index at the call site, that is the caller's business. unpack-trees.c should not make any assumption about that and should use the correct index field in unpack_trees_options.