Re: [PATCH/RFC/GSoC 16/17] editor: implement git_sequence_editor() and launch_sequence_editor()

Hi Paul, On Wed, 16 Mar 2016, Paul Tan wrote: > Hi Dscho, > > On Tue, Mar 15, 2016 at 3:00 PM, Johannes Schindelin > wrote: > > On Sat, 12 Mar 2016, Paul Tan wrote: > >> --- > >> cache.h | 1 + > > > > No need to clutter cache.h with a function that is only to be

Re: [PATCH/RFC/GSoC 16/17] editor: implement git_sequence_editor() and launch_sequence_editor()

Hi Dscho, On Tue, Mar 15, 2016 at 3:00 PM, Johannes Schindelin wrote: > On Sat, 12 Mar 2016, Paul Tan wrote: >> --- >> cache.h | 1 + > > No need to clutter cache.h with a function that is only to be used by the > sequencer. IOW let's make this static in

Re: [PATCH/RFC/GSoC 16/17] editor: implement git_sequence_editor() and launch_sequence_editor()

Hi Paul, On Sat, 12 Mar 2016, Paul Tan wrote: > Signed-off-by: Paul Tan This commit message is very short. > --- > cache.h | 1 + No need to clutter cache.h with a function that is only to be used by the sequencer. IOW let's make this static in sequencer.c. I would

[PATCH/RFC/GSoC 16/17] editor: implement git_sequence_editor() and launch_sequence_editor()

Signed-off-by: Paul Tan --- cache.h | 1 + editor.c | 27 +-- strbuf.h | 1 + 3 files changed, 27 insertions(+), 2 deletions(-) diff --git a/cache.h b/cache.h index aa5e97c..d7a6fc6 100644 --- a/cache.h +++ b/cache.h @@ -1222,6 +1222,7 @@ extern