Re: [PATCH/RFC] branch: add tests for new copy branch feature

2017-06-13 Thread Jonathan Nieder
Ævar Arnfjörð Bjarmason wrote: > On Tue, Jun 13 2017, Jonathan Nieder jotted: > > Ævar Arnfjörð Bjarmason wrote: >>> My understanding of that last part is that Jonathan/someone (see >>> reported-by in that patch) had some script which was renaming >>> branches, and it was easier for whatever

Re: [PATCH/RFC] branch: add tests for new copy branch feature

2017-06-13 Thread Ævar Arnfjörð Bjarmason
On Tue, Jun 13 2017, Jonathan Nieder jotted: > Hi, > > Ævar Arnfjörð Bjarmason wrote: > >> So the reason we have this for -m is: >> >> commit 3f59481e33 >> Author: Jonathan Nieder >> Date: Fri Nov 25 20:30:02 2011 -0600 >> >> branch: allow a no-op "branch

Re: [PATCH/RFC] branch: add tests for new copy branch feature

2017-06-13 Thread Jonathan Nieder
Hi, Ævar Arnfjörð Bjarmason wrote: > So the reason we have this for -m is: > > commit 3f59481e33 > Author: Jonathan Nieder > Date: Fri Nov 25 20:30:02 2011 -0600 > > branch: allow a no-op "branch -M HEAD" > > Overwriting the current branch with a

Re: [PATCH/RFC] branch: add tests for new copy branch feature

2017-05-29 Thread Sahil Dua
On Mon, May 29, 2017 at 10:50 PM, Ævar Arnfjörð Bjarmason wrote: > On Mon, May 29, 2017 at 10:41 PM, Sahil Dua wrote: >> On Mon, May 29, 2017 at 1:30 AM, Ævar Arnfjörð Bjarmason >> wrote: >>> On Mon, May 29, 2017 at 12:56 AM, Sahil Dua

Re: [PATCH/RFC] branch: add tests for new copy branch feature

2017-05-29 Thread Ævar Arnfjörð Bjarmason
On Mon, May 29, 2017 at 10:41 PM, Sahil Dua wrote: > On Mon, May 29, 2017 at 1:30 AM, Ævar Arnfjörð Bjarmason > wrote: >> On Mon, May 29, 2017 at 12:56 AM, Sahil Dua wrote: >>> New feature - copying a branch along with its config

Re: [PATCH/RFC] branch: add tests for new copy branch feature

2017-05-29 Thread Sahil Dua
On Mon, May 29, 2017 at 1:30 AM, Ævar Arnfjörð Bjarmason wrote: > On Mon, May 29, 2017 at 12:56 AM, Sahil Dua wrote: >> New feature - copying a branch along with its config section. >> >> Aim is to have an option -c for copying a branch just like -m

Re: [PATCH/RFC] branch: add tests for new copy branch feature

2017-05-29 Thread Sahil Dua
Thanks, Junio for raising all these important questions. Indeed, showing tests in order to explain my thinking about the feature was a bad idea. I realise that I should have explained the feature first instead of getting the tests reviewed without any elaboration of the intentions. I will explain

Re: [PATCH/RFC] branch: add tests for new copy branch feature

2017-05-28 Thread Junio C Hamano
Sahil Dua writes: > New feature - copying a branch along with its config section. That's an unusual non-sentence (without a verb) in our commit message. > Aim is to have an option -c for copying a branch just like -m option for > renaming a branch. What should it copy

Re: [PATCH/RFC] branch: add tests for new copy branch feature

2017-05-28 Thread Ævar Arnfjörð Bjarmason
On Mon, May 29, 2017 at 12:56 AM, Sahil Dua wrote: > New feature - copying a branch along with its config section. > > Aim is to have an option -c for copying a branch just like -m option for > renaming a branch. > > This commit adds a few basic tests for getting any

[PATCH/RFC] branch: add tests for new copy branch feature

2017-05-28 Thread Sahil Dua
New feature - copying a branch along with its config section. Aim is to have an option -c for copying a branch just like -m option for renaming a branch. This commit adds a few basic tests for getting any suggestions/feedback about expected behavior for this new feature. Signed-off-by: Sahil