Re: [PATCH/RFC] builtin: move builtin retrieval to get_builtin()

2014-11-17 Thread Junio C Hamano
Slavomir Vlcek writes: > I noticed that the patch has been modified (suggested 'static' > scope modification, commit message) and added to the 'next' > branch. So does this mean my task is done [...]? Even after the change hits 'next', other people may still find problems and rooms for improveme

Re: [PATCH/RFC] builtin: move builtin retrieval to get_builtin()

2014-11-16 Thread Slavomir Vlcek
On 11/13/2014 07:19 PM, Junio C Hamano wrote: >> git.c | 27 +++ >> 1 file changed, 15 insertions(+), 12 deletions(-) >> >> diff --git a/git.c b/git.c >> index 18fbf79..e32c5b8 100644 >> --- a/git.c >> +++ b/git.c >> @@ -487,15 +487,20 @@ static struct cmd_struct commands[]

Re: [PATCH/RFC] builtin: move builtin retrieval to get_builtin()

2014-11-13 Thread Junio C Hamano
slavomir vlcek writes: > Hi, > found a small code redundancy in a builtin command retrieval ('git.c'). > > For the "master" branch. > > Thanks in advance for any suggestions. > > Signed-off-by: slavomir vlcek > --- Thanks. Please do realize that all of the above before the three-dash line and

[PATCH/RFC] builtin: move builtin retrieval to get_builtin()

2014-11-12 Thread slavomir vlcek
Hi, found a small code redundancy in a builtin command retrieval ('git.c'). For the "master" branch. Thanks in advance for any suggestions. Signed-off-by: slavomir vlcek --- >From 78228e3f7c3029d07827f973fa7992777d6e0cb9 Mon Sep 17 00:00:00 2001 From: slavomir vlcek Date: Wed, 12 Nov 2014 14: