Re: [PATCH/RFC] checkout: print something when checking out paths

2018-11-19 Thread Junio C Hamano
Duy Nguyen writes: >> > I see this at the same level as "Switched to branch 'foo'" which is >> > also protected by opts->quiet. If we start hiding messages based on >> > tty it should be done for other messages in update_refs_for_switch() >> > too, I guess? > > No let's drop this for now. I

Re: [PATCH/RFC] checkout: print something when checking out paths

2018-11-19 Thread Duy Nguyen
On Mon, Nov 19, 2018 at 2:08 PM Ævar Arnfjörð Bjarmason wrote: > > > On Mon, Nov 12 2018, Duy Nguyen wrote: > > > On Mon, Nov 12, 2018 at 7:21 AM Junio C Hamano wrote: > >> > >> Nguyễn Thái Ngọc Duy writes: > >> > >> > Since the purpose of printing this is to help disambiguate. Only do it > >>

Re: [PATCH/RFC] checkout: print something when checking out paths

2018-11-19 Thread Ævar Arnfjörð Bjarmason
On Mon, Nov 12 2018, Duy Nguyen wrote: > On Mon, Nov 12, 2018 at 7:21 AM Junio C Hamano wrote: >> >> Nguyễn Thái Ngọc Duy writes: >> >> > Since the purpose of printing this is to help disambiguate. Only do it >> > when "--" is missing (the actual reason though is many tests check >> > empty

Re: [PATCH/RFC] checkout: print something when checking out paths

2018-11-12 Thread Junio C Hamano
Duy Nguyen writes: > Another thing I'm going to change (if this v1 is in the right > direction): print different messages for "git checkout -- foo" and > "git checkout foo -- bar". The first one is "%d paths have been > reverted" but the second one does different things and probably should > say

Re: [PATCH/RFC] checkout: print something when checking out paths

2018-11-12 Thread Duy Nguyen
On Mon, Nov 12, 2018 at 7:21 AM Junio C Hamano wrote: > > Nguyễn Thái Ngọc Duy writes: > > > Since the purpose of printing this is to help disambiguate. Only do it > > when "--" is missing (the actual reason though is many tests check > > empty stderr to see that no error is raised and I'm too

Re: [PATCH/RFC] checkout: print something when checking out paths

2018-11-11 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Since the purpose of printing this is to help disambiguate. Only do it > when "--" is missing (the actual reason though is many tests check > empty stderr to see that no error is raised and I'm too lazy to fix > all the test cases). Heh, honesty is good but in

[PATCH/RFC] checkout: print something when checking out paths

2018-11-10 Thread Nguyễn Thái Ngọc Duy
One of the problems with "git checkout" is that it does so many different things and could confuse people specially when we fail to handle ambiguation correctly. One way to help with that is tell the user what sort of operation is actually carried out. When switching branches, we always print