Re: [PATCH/RFC] commit-template: improve readability of commit template

2017-06-28 Thread Kaartic Sivaraam
I might have been ignorant about something about git in my reply in the previous email (found below). In that case, please enlighten me. On Wed, 2017-06-28 at 18:34 +0530, Kaartic Sivaraam wrote: > On Tue, 2017-06-27 at 10:56 -0700, Junio C Hamano wrote: > > Kaartic Sivaraam

Re: [PATCH/RFC] commit-template: improve readability of commit template

2017-06-28 Thread Kaartic Sivaraam
On Tue, 2017-06-27 at 10:56 -0700, Junio C Hamano wrote: > Kaartic Sivaraam writes: > > I thought it's not good to trade-off readability for vertical space > > as > > the ultimate aim of the commit template (at least to me) is to > > convey > > information to the

Re: [PATCH/RFC] commit-template: improve readability of commit template

2017-06-27 Thread Junio C Hamano
Kaartic Sivaraam writes: >> I personally do not find these new blank lines are necessary, and >> this change wastes vertical screen real estate which is a limited >> resource, but that may be just me. I on the other hand do not think >> the result of this patch

Re: [PATCH/RFC] commit-template: improve readability of commit template

2017-06-27 Thread Kaartic Sivaraam
On Mon, 2017-06-26 at 14:59 -0700, Junio C Hamano wrote: > We don't usually make a bullet list in log message.  Please stick to > a plain prose.   > > "Previously" is superflous.  Say what it does (e.g. "The commit > template adds optional parts without extra blank lines to its normal > output")

Re: [PATCH/RFC] commit-template: improve readability of commit template

2017-06-26 Thread Junio C Hamano
Kaartic Sivaraam writes: > * Previously the commit template didn't separate the > distinct messages shown. This resulted in difficulty > in interpreting it's content. Add new lines to separate > the distinct parts of the template. > > * Previously the

[PATCH/RFC] commit-template: improve readability of commit template

2017-06-26 Thread Kaartic Sivaraam
* Previously the commit template didn't separate the distinct messages shown. This resulted in difficulty in interpreting it's content. Add new lines to separate the distinct parts of the template. * Previously the warning about usage of explicit paths without any options wasn't clear.