Re: [PATCH/RFC] completion: complete all possible -no-

2018-05-14 Thread Andreas Heiduk
Am 14.05.2018 um 19:26 schrieb Duy Nguyen: > On Mon, May 14, 2018 at 7:03 PM, Andreas Heiduk wrote: >> Am 08.05.2018 um 17:24 schrieb Duy Nguyen: >>> On Mon, Apr 23, 2018 at 7:36 AM, Eric Sunshine >>> wrote: I haven't looked at the

Re: [PATCH/RFC] completion: complete all possible -no-

2018-05-14 Thread Duy Nguyen
On Mon, May 14, 2018 at 7:03 PM, Andreas Heiduk wrote: > Am 08.05.2018 um 17:24 schrieb Duy Nguyen: >> On Mon, Apr 23, 2018 at 7:36 AM, Eric Sunshine >> wrote: >>> I haven't looked at the implementation, so this may be an entirely >>> stupid

Re: [PATCH/RFC] completion: complete all possible -no-

2018-05-14 Thread Duy Nguyen
On Wed, May 9, 2018 at 5:20 AM, Aaron Schrab wrote: > At 17:24 +0200 08 May 2018, Duy Nguyen wrote: >> >> It took me so long to reply partly because I remember seeing some guy >> doing clever trick with tab completion that also shows a short help >> text in

Re: [PATCH/RFC] completion: complete all possible -no-

2018-05-14 Thread Andreas Heiduk
Am 08.05.2018 um 17:24 schrieb Duy Nguyen: > On Mon, Apr 23, 2018 at 7:36 AM, Eric Sunshine > wrote: >> I haven't looked at the implementation, so this may be an entirely >> stupid suggestion, but would it be possible to instead render the >> completions as? >> >> %

Re: [PATCH/RFC] completion: complete all possible -no-

2018-05-14 Thread Duy Nguyen
On Mon, May 14, 2018 at 5:33 AM, Eric Sunshine wrote: > It _might_ feel as bit less weird if it was presented as --no- > or --no-{...} or --no-<...> or --no-... or something, but those seem > pretty weird too, so perhaps not. Anyhow, it's not a major issue; the >

Re: [PATCH/RFC] completion: complete all possible -no-

2018-05-13 Thread Eric Sunshine
On Tue, May 8, 2018 at 11:24 AM, Duy Nguyen wrote: > On Mon, Apr 23, 2018 at 7:36 AM, Eric Sunshine > wrote: >> I haven't looked at the implementation, so this may be an entirely >> stupid suggestion, but would it be possible to instead render the >>

Re: [PATCH/RFC] completion: complete all possible -no-

2018-05-08 Thread Aaron Schrab
At 17:24 +0200 08 May 2018, Duy Nguyen wrote: It took me so long to reply partly because I remember seeing some guy doing clever trick with tab completion that also shows a short help text in addition to the complete words. I could not find that again and from my reading

Re: [PATCH/RFC] completion: complete all possible -no-

2018-05-08 Thread Stefan Beller
On Tue, May 8, 2018 at 8:24 AM, Duy Nguyen wrote: > I'm arguing about this because I want to see your reaction, because > I'm thinking of doing the very same thing for config completion. Right > now "git config " gives you two pages of all available config > variables. I'm

Re: [PATCH/RFC] completion: complete all possible -no-

2018-05-08 Thread Duy Nguyen
On Mon, Apr 23, 2018 at 7:36 AM, Eric Sunshine wrote: > I haven't looked at the implementation, so this may be an entirely > stupid suggestion, but would it be possible to instead render the > completions as? > > % git checkout -- > --[no-]conflict=

Re: [PATCH/RFC] completion: complete all possible -no-

2018-04-22 Thread Eric Sunshine
On Tue, Apr 17, 2018 at 2:13 PM, Nguyễn Thái Ngọc Duy wrote: > The problem with completing --no- form is that the number of > completable options now usually doubles, taking precious screen space > and also making it hard to find the option you want. > > So the other half of

Re: [PATCH/RFC] completion: complete all possible -no-

2018-04-18 Thread Duy Nguyen
On Wed, Apr 18, 2018 at 5:43 AM, Junio C Hamano wrote: > So, the earlier mention of "clone --no-checkout" sounded about not > losing this historical practice, but (desirabilty of magic number 4 > aside) this "show first handful of --no-foo" feature is not about > historical

Re: [PATCH/RFC] completion: complete all possible -no-

2018-04-17 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > So the other half of this patch, the part in git-completion.bash, is > to uncomplete --no- options. When you do "git checkout --", > instead of displaying all --no- options, this patch simply displays > one item: the --no- prefix. If you do "git

[PATCH/RFC] completion: complete all possible -no-

2018-04-17 Thread Nguyễn Thái Ngọc Duy
This is not a complete topic but I'd like to present the problem and my approach to see if it's a good way to go. We have started recently to rely on parse-options to help complete options. One of the leftover items is allowing completing --no- form. This patch enables that (some options should