Re: [PATCH/RFC] git-svn: don't create master if another head exists

2012-07-19 Thread Eric Wong
Marcin Owsiany mar...@owsiany.pl wrote: On Wed, Jul 18, 2012 at 11:27:22AM +, Eric Wong wrote: Marcin Owsiany mar...@owsiany.pl wrote: Turns out that command_noisy() - has a meaningless return value - throws an exception on command failure so the || bit does not work. Also,

Re: [PATCH/RFC] git-svn: don't create master if another head exists

2012-07-19 Thread Junio C Hamano
Eric Wong normalper...@yhbt.net writes: Probably, I'm not sure if it'd break existing uses. Anyways, that's a separate issue we can deal with another day. I've added my Signed-off-by: to your latest patch and pushed to master of git://bogomips.org/git-svn.git (commit

Re: [PATCH/RFC] git-svn: don't create master if another head exists

2012-07-18 Thread Marcin Owsiany
Thanks for the review! On Wed, Jul 11, 2012 at 03:56:43PM -0700, Junio C Hamano wrote: Marcin Owsiany mar...@owsiany.pl writes: Date: Sun, 24 Jun 2012 22:40:05 +0100 Subject: [PATCH] git-svn: don't create master if another head exists git-svn insists on creating the master head (unless

Re: [PATCH/RFC] git-svn: don't create master if another head exists

2012-07-18 Thread Marcin Owsiany
On Wed, Jul 18, 2012 at 11:27:22AM +, Eric Wong wrote: Marcin Owsiany mar...@owsiany.pl wrote: On Wed, Jul 11, 2012 at 03:56:43PM -0700, Junio C Hamano wrote: If the caller does not handle errors, it could be even clearer to write it like command_noisy(qw(update-ref HEAD),

Re: [PATCH/RFC] git-svn: don't create master if another head exists

2012-07-18 Thread Junio C Hamano
Marcin Owsiany mar...@owsiany.pl writes: PTAL: From: Marcin Owsiany mar...@owsiany.pl Date: Sun, 24 Jun 2012 22:40:05 +0100 Subject: [PATCH] git-svn: don't create master if another head exists git-svn insists on creating the master head (unless it exists) on every fetch. It is useful that

Re: [PATCH/RFC] git-svn: don't create master if another head exists

2012-07-11 Thread Marcin Owsiany
On Wed, Jul 11, 2012 at 01:26:17AM +, Eric Wong wrote: Junio C Hamano gits...@pobox.com wrote: Marcin Owsiany mar...@owsiany.pl writes: This makes my idea to do the same to my something else instead of master much less attractive. In fact I don't think such behaviour would be

Re: [PATCH/RFC] git-svn: don't create master if another head exists

2012-07-11 Thread Junio C Hamano
Marcin Owsiany mar...@owsiany.pl writes: Date: Sun, 24 Jun 2012 22:40:05 +0100 Subject: [PATCH] git-svn: don't create master if another head exists git-svn insists on creating the master head (unless it exists) on every fetch. It is useful that it gets created initially, when no head exists

Re: [PATCH/RFC] git-svn: don't create master if another head exists

2012-07-10 Thread Eric Wong
Junio C Hamano gits...@pobox.com wrote: Marcin Owsiany mar...@owsiany.pl writes: This makes my idea to do the same to my something else instead of master much less attractive. In fact I don't think such behaviour would be useful. I think with the suggested patch git-svn works as I

Re: [PATCH/RFC] git-svn: don't create master if another head exists

2012-07-09 Thread Marcin Owsiany
On Tue, Jun 26, 2012 at 11:32:15PM +0100, Marcin Owsiany wrote: On Tue, Jun 26, 2012 at 03:03:07PM -0700, Junio C Hamano wrote: Marcin Owsiany mar...@owsiany.pl writes: diff --git a/git-svn.perl b/git-svn.perl index 0b074c4..2379a71 100755 --- a/git-svn.perl +++ b/git-svn.perl

Re: [PATCH/RFC] git-svn: don't create master if another head exists

2012-07-09 Thread Junio C Hamano
Marcin Owsiany mar...@owsiany.pl writes: This makes my idea to do the same to my something else instead of master much less attractive. In fact I don't think such behaviour would be useful. I think with the suggested patch git-svn works as I would like it to: - creates master at initial