Re: [PATCH/RFC 0/5] win32: support echo for terminal-prompt

2012-11-30 Thread Erik Faye-Lund
Ping? On Tue, Nov 13, 2012 at 3:04 PM, Erik Faye-Lund kusmab...@gmail.com wrote: We currently only support getpass, which does not echo at all, for git_terminal_prompt on Windows. The Windows console is perfectly capable of doing this, so let's make it so. This implementation tries to reuse

Re: [PATCH/RFC 0/5] win32: support echo for terminal-prompt

2012-11-30 Thread Jeff King
On Fri, Nov 30, 2012 at 11:16:59AM +0100, Erik Faye-Lund wrote: Ping? Thanks for the reminder; your initial series came while I was traveling. I think it looks good. The compat/terminal code ends up a little uglier, but I think you overall did a good job of balancing code reuse across

[PATCH/RFC 0/5] win32: support echo for terminal-prompt

2012-11-13 Thread Erik Faye-Lund
We currently only support getpass, which does not echo at all, for git_terminal_prompt on Windows. The Windows console is perfectly capable of doing this, so let's make it so. This implementation tries to reuse the /dev/tty-code as much as possible. The big reason that this becomes a bit hairy