Re: [PATCH/RFC 06/10] strbuf: introduce strbuf_split_str_without_term()

2015-12-12 Thread Karthik Nayak
On Sat, Dec 12, 2015 at 4:01 AM, Junio C Hamano wrote: > Karthik Nayak writes: > diff --git a/ref-filter.c b/ref-filter.c @@ -892,14 +892,11 @@ static void populate_value(struct ref_array_item *ref) * TODO:

Re: [PATCH/RFC 06/10] strbuf: introduce strbuf_split_str_without_term()

2015-12-11 Thread Junio C Hamano
Karthik Nayak writes: >>> diff --git a/ref-filter.c b/ref-filter.c >>> @@ -892,14 +892,11 @@ static void populate_value(struct ref_array_item *ref) >>> * TODO: Implement a function similar to >>> strbuf_split_str() >>> *

Re: [PATCH/RFC 06/10] strbuf: introduce strbuf_split_str_without_term()

2015-12-03 Thread Karthik Nayak
On Wed, Dec 2, 2015 at 1:34 PM, Eric Sunshine wrote: > On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak wrote: >> The current implementation of 'strbuf_split_buf()' includes the >> terminator at the end of each strbuf post splitting. Include an

Re: [PATCH/RFC 06/10] strbuf: introduce strbuf_split_str_without_term()

2015-12-02 Thread Eric Sunshine
On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak wrote: > The current implementation of 'strbuf_split_buf()' includes the > terminator at the end of each strbuf post splitting. Include an option s/Include an/Add an/ > wherein we can drop the terminator if required. In this

[PATCH/RFC 06/10] strbuf: introduce strbuf_split_str_without_term()

2015-11-11 Thread Karthik Nayak
The current implementation of 'strbuf_split_buf()' includes the terminator at the end of each strbuf post splitting. Include an option wherein we can drop the terminator if required. In this context introduce a wrapper function 'strbuf_split_str_without_term()' which splits a given string into