Re: [PATCH/RFC v3 02/12] pack-objects: turn type and in_pack_type to bitfields

On Fri, Mar 09, 2018 at 02:54:53PM -0800, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > > > @@ -1570,7 +1576,7 @@ static void drop_reused_delta(struct object_entry > > *entry) > > entry->depth = 0; > > > > oi.sizep = >size; > > - oi.typep = >type; > > +

Re: [PATCH/RFC v3 02/12] pack-objects: turn type and in_pack_type to bitfields

Nguyễn Thái Ngọc Duy writes: > @@ -1570,7 +1576,7 @@ static void drop_reused_delta(struct object_entry > *entry) > entry->depth = 0; > > oi.sizep = >size; > - oi.typep = >type; > + oi.typep = > if (packed_object_info(entry->in_pack,

[PATCH/RFC v3 02/12] pack-objects: turn type and in_pack_type to bitfields

This saves 8 bytes in sizeof(struct object_entry). On a large repository like linux-2.6.git (6.5M objects), this saves us 52MB memory. Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/pack-objects.c | 14 -- cache.h| 2 ++ object.h |