Re: [PATCH/RFC v3 08/12] pack-objects: refer to delta objects by index instead of pointer

2018-03-14 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Notice that packing_data::nr_objects is uint32_t, we could only handle > maximum 4G objects and can address all of them with an uint32_t. If we > use a pointer here, we waste 4 bytes on 64 bit architecture. Some things are left unsaid or left

[PATCH/RFC v3 08/12] pack-objects: refer to delta objects by index instead of pointer

2018-03-08 Thread Nguyễn Thái Ngọc Duy
Notice that packing_data::nr_objects is uint32_t, we could only handle maximum 4G objects and can address all of them with an uint32_t. If we use a pointer here, we waste 4 bytes on 64 bit architecture. Convert these delta pointers to indexes. Since we need to handle NULL pointers as well, the