Re: [PATCH/RFC v4 01/16] GSOC remote-svn

2012-08-20 Thread Florian Achleitner
On Saturday 18 August 2012 23:35:38 Junio C Hamano wrote: Junio C Hamano gits...@pobox.com writes: [..] Just to show how, here is what I did just now. [..] Thanks. Thanks for you guidance! I'll base a new version on your fixups. Florian -- To unsubscribe from this list: send the line

Re: [PATCH/RFC v4 01/16] GSOC remote-svn

2012-08-20 Thread Florian Achleitner
On Saturday 18 August 2012 13:13:47 Junio C Hamano wrote: That indicates that one necessary patch to add logic to Makefile to go and build that subdirectory, at least before running the test, but possibly as part of the all target, is missing, isn't it? Or you can add, at the beginning of

Re: [PATCH/RFC v4 01/16] GSOC remote-svn

2012-08-20 Thread Junio C Hamano
Florian Achleitner florian.achleitner.2.6...@gmail.com writes: On Saturday 18 August 2012 13:13:47 Junio C Hamano wrote: That indicates that one necessary patch to add logic to Makefile to go and build that subdirectory, at least before running the test, but possibly as part of the all

Re: [PATCH/RFC v4 01/16] GSOC remote-svn

2012-08-20 Thread Jonathan Nieder
Hi, Florian Achleitner wrote: What version would you prefer? I think git-remote-svn should move out of contrib to the toplevel of git.git (as I think I've mentioned before). Since it's just a new git command in incubation, I don't want the maintenance hassle of keeping it in contrib/svn-fe.

Re: [PATCH/RFC v4 01/16] GSOC remote-svn

2012-08-19 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Florian Achleitner florian.achleitner.2.6...@gmail.com writes: On Friday 17 August 2012 21:16:59 Junio C Hamano wrote: Comments from mentors and people interested in remote helpers? I did minimum line wrapping, typofix and small compilation fixes

Re: [PATCH/RFC v4 01/16] GSOC remote-svn

2012-08-18 Thread Florian Achleitner
On Friday 17 August 2012 21:16:59 Junio C Hamano wrote: Comments from mentors and people interested in remote helpers? I did minimum line wrapping, typofix and small compilation fixes and queued these on 'pu'; I think I saw one commit whose message I didn't quite get what it was trying to

[PATCH/RFC v4 01/16] GSOC remote-svn

2012-08-17 Thread Florian Achleitner
Hi! Thanks for the reviews! This series contains the follwing improvements. I decided to summarize them here, sorted by topic instead of attaching them to the patches. all: - remove all merge garbage and debugging legacy (hopefully). - reviews: style - reorder patches remote-svn: - review: