Remi Lespinet remi.lespi...@ensimag.grenoble-inp.fr writes:
Matthieu Moy matthieu@grenoble-inp.fr writes:
Cool. Then almost all the work is done to get an automated test. Next
step would be to add the tests itself in the code. I would do that by
adding a hidden --selfcheck option to git
Remi Lespinet remi.lespi...@ensimag.grenoble-inp.fr writes:
I've some more tests, maybe I should put them all in this post ?
Yes, please post as much as you have. Ideally, this should be
automatically tested, but if you don't have time to write the automated
tests, at least having a track of
Remi Lespinet remi.lespi...@ensimag.grenoble-inp.fr writes:
Remi Lespinet remi.lespi...@ensimag.grenoble-inp.fr writes:
I've some more tests, maybe I should put them all in this post ?
Yes, please post as much as you have. Ideally, this should be
automatically tested, but if you don't
Matthieu Moy matthieu@grenoble-inp.fr writes:
Cool. Then almost all the work is done to get an automated test. Next
step would be to add the tests itself in the code. I would do that by
adding a hidden --selfcheck option to git send-email that would compare
Mail::Address-parse($string);
Matthieu Moy matthieu@grenoble-inp.fr writes
+ my $commentrgx=qr/\((?:[^)]*)\)/;
+ my $quotergx=qr/(?:[^\\\]|\\.)*/;
+ my $wordrgx=qr/(?:[^][\s():;@\\,.]|\\.)+/;
Spaces around = please.
...
+ foreach my $token (@tokens) {
+ if ($token =~ /^[,;]$/) {
Here and
Junio C Hamano gits...@pobox.com writes
Suffix rgx that means regular expression is a bit unusual, and
also hard to read when squashed to another word. Elsewhere in the
same script, we seem to use $re_whatever to store precompiled
regular expressions, so perhaps $re_comment, $re_quote, etc.?
Remi Lespinet remi.lespi...@ensimag.grenoble-inp.fr writes:
parse_address_line had not the same behavior whether the user had
Mail::Address or not. Teach parse_address_line to behave like
Mail::Address.
Sounds like a fun project ;-)
+ my $commentrgx=qr/\((?:[^)]*)\)/;
+ my
parse_address_line had not the same behavior whether the user had
Mail::Address or not. Teach parse_address_line to behave like
Mail::Address.
When the user input is correct, this implementation behaves
exactly like Mail::Address except when there are quotes
inside the name:
Jane Doe
Remi Lespinet remi.lespi...@ensimag.grenoble-inp.fr writes:
---
git-send-email.perl | 54
+++--
1 file changed, 52 insertions(+), 2 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index a0cd7ff..a1f6c18 100755
---
9 matches
Mail list logo
