Junio C Hamano gits...@pobox.com writes:
As long as what is given to 'drop'
is checked when it matters (e.g. when the code in patch 2/2 tries
see if some commits in the original list are no longer there in
order to warn sees drop foo bar where foo is obviously not an
object name in the
Remi Galan Alfonso remi.galan-alfo...@ensimag.grenoble-inp.fr
writes:
Junio C Hamano gits...@pobox.com writes:
As long as what is given to 'drop'
is checked when it matters (e.g. when the code in patch 2/2 tries
see if some commits in the original list are no longer there in
order to
Remi Galan Alfonso remi.galan-alfo...@ensimag.grenoble-inp.fr writes:
Ideally, I think we should do a sanity check before starting the rebase,
and error out if we encounter an invalid command, a command that should
be followed by a valid sha1 and does not, ...
But currently, we do the
Ideally, I think we should do a sanity check before starting the rebase,
and error out if we encounter an invalid command, a command that should
be followed by a valid sha1 and does not, ...
But currently, we do the verification while applying commands, and I
don't think there's anything
Matthieu Moy matthieu@grenoble-inp.fr writes:
Discussions on this list often lead to Oh, BTW, shall we do XYZ also?,
but you shouldn't take this kind of remark as blocking (as long as XYZ
is not incompatible with your patch, which is the case here).
Yeah, thanks for clarification. As
Instead of removing a line to remove the commit, you can use the
command drop (just like pick or edit). It has the same effect as
deleting the line (removing the commit) except that you keep a visual
trace of your actions, allowing a better control and reducing the
possibility of removing a commit
Instead of removing a line to remove the commit, you can use the
command drop (just like pick or edit). It has the same effect as
deleting the line (removing the commit) except that you keep a visual
trace of your actions, allowing a better control and reducing the
possibility of removing a commit
Galan Rémi remi.galan-alfo...@ensimag.grenoble-inp.fr writes:
Instead of removing a line to remove the commit, you can use the
command drop (just like pick or edit). It has the same effect as
deleting the line (removing the commit) except that you keep a visual
trace of your actions,
Junio C Hamano gits...@pobox.com writes:
Galan Rémi remi.galan-alfo...@ensimag.grenoble-inp.fr writes:
Instead of removing a line to remove the commit, you can use the
command drop (just like pick or edit). It has the same effect as
deleting the line (removing the commit) except that you
Junio C Hamano gits...@pobox.com writes:
Is this sufficient?
If you are going to do something in 2/2 that relies on the format of
this line being correct (as opposed to noop or # that can have
any garbage on the remainder of the line), wouldn't you want to at
least check $sha1 is sensible?
10 matches
Mail list logo
