Re: [PATCH][GSOC2014] install_branch_config: change logical chain to lookup table

2014-03-17 Thread Eric Sunshine
On Fri, Mar 14, 2014 at 5:30 PM, TamerTas tamer...@outlook.com wrote: Signed-off-by: TamerTas tamer...@outlook.com --- Thanks again for the feedback it's been a great learning experience. Comments Below :) I have refactored the commit [1] to * suggested changes [2]. format-patch was

[PATCH][GSOC2014] install_branch_config: change logical chain to lookup table

2014-03-14 Thread TamerTas
Signed-off-by: TamerTas tamer...@outlook.com --- Thanks again for the feedback it's been a great learning experience. Comments Below :) I have refactored the commit [1] to * suggested changes [2]. format-patch was placing 2 hyphens instead of 3 but it's fixed now. I've turned the table into a

Re: [PATCH][GSOC2014] install_branch_config: change logical chain to lookup table

2014-03-13 Thread Eric Sunshine
On Wed, Mar 12, 2014 at 5:24 PM, TamerTas tamer...@outlook.com wrote: Signed-off-by: TamerTas tamer...@outlook.com -- There should be three hyphens --- here but somehow you have only two --. Since --- is detected automatically when the patch is applied, this deviation can be problematic.