[PATCH] [GSoC] Use strchrnul to save additional scan of string

2014-03-14 Thread Shubham Chaudhary
From c422507408824403ed18e89ec0bbc32b8764e09c Mon Sep 17 00:00:00 2001 From: Shubham Chaudhary shubham.chaudh...@kdemail.net Date: Sat, 15 Mar 2014 05:56:18 +0530 Subject: [PATCH] [GSoC] Use strchrnul to save additional scan of string Some strings are scanned twice unnecessarily, once with strchr

Re: [PATCH] [GSoC] Use strchrnul to save additional scan of string

2014-03-14 Thread Jeff King
Subject: [PATCH] [GSoC] Use strchrnul to save additional scan of string And these are redundant with your mail headers. You can drop all of them. Your patch also appears to be whitespace-damaged (it looks like extra wrawpping). Consider using git-send-email, which takes care of all of these issues