[PATCH 1/1] templates: pre-push hook: check for missing GPG signatures (was: Re: [PATCH] Add .gitconfig variable commit.gpg-sign)

On 04/24/2013 11:51 AM, Michael J Gruber wrote: > Sebastian Götte venit, vidit, dixit 24.04.2013 10:53: >> What could be nice would be a >> config option that makes "git push" warn/abort in case I try to push an >> unsigned head commit to a repo where I wan

Re: [PATCH] Add .gitconfig variable commit.gpg-sign

Sebastian Götte venit, vidit, dixit 24.04.2013 10:53: > On 04/23/2013 09:56 PM, Joel Jacobson wrote: >>> But stepping back a bit, I have a suspicion that your upstream >>> project _only_ cares about what you feed them (either by pushing >>> your work yourself to them, or telling them to pull from y

Re: [PATCH] Add .gitconfig variable commit.gpg-sign

On 04/23/2013 09:56 PM, Joel Jacobson wrote: >> But stepping back a bit, I have a suspicion that your upstream >> project _only_ cares about what you feed them (either by pushing >> your work yourself to them, or telling them to pull from your >> repository). There is no reason for you to be const

Re: [PATCH] Add .gitconfig variable commit.gpg-sign

On Tue, Apr 23, 2013 at 8:25 PM, Junio C Hamano wrote: > Yup. > > And then we would need to add the same option to existing callers of > "git commit" (such as "git rebase") to pass it down the callchain. Got it. > But stepping back a bit, I have a suspicion that your upstream > project _only_ ca

Re: [PATCH] Add .gitconfig variable commit.gpg-sign

Joel Jacobson writes: > On Tue, Apr 23, 2013 at 6:53 PM, Junio C Hamano wrote: >> I would consider such use of "git -c key=val" a last-resort escape >> hatch to work around broken commands that do not implement a proper >> escape hatch designed in to help users, unless the "key" is for >> someth

Re: [PATCH] Add .gitconfig variable commit.gpg-sign

On Tue, Apr 23, 2013 at 6:53 PM, Junio C Hamano wrote: > I would consider such use of "git -c key=val" a last-resort escape > hatch to work around broken commands that do not implement a proper > escape hatch designed in to help users, unless the "key" is for > something very obscure and not meant

Re: [PATCH] Add .gitconfig variable commit.gpg-sign

Michael J Gruber writes: > As for the command line override: > > Don't we have "git -c commit.gpgsign=false" and such these days, so that > we don't have to inflate options any more? I would consider such use of "git -c key=val" a last-resort escape hatch to work around broken commands that do n

Re: [PATCH] Add .gitconfig variable commit.gpg-sign

Junio C Hamano writes: > Joel Jacobson writes: > >> Signed-off-by: Joel Jacobson >> --- >> builtin/commit.c | 4 +++- > > No docs? No tests? > > As to the design, any regular configuration variable settings must > be overridable from the command line for a single invocation. Please > design an

Re: [PATCH] Add .gitconfig variable commit.gpg-sign

Joel Jacobson venit, vidit, dixit 23.04.2013 02:00: > On Tue, Apr 23, 2013 at 12:43 AM, Junio C Hamano wrote: >> No docs? No tests? > > Maybe simply adding this text to git-commit.txt, > > The default can be changed by the 'commit.gpg-sign' configuration > variable (see linkgit:git-config[1]).

Re: [PATCH] Add .gitconfig variable commit.gpg-sign

On Tue, Apr 23, 2013 at 12:43 AM, Junio C Hamano wrote: > No docs? No tests? Maybe simply adding this text to git-commit.txt, The default can be changed by the 'commit.gpg-sign' configuration variable (see linkgit:git-config[1]). after, -S[]:: --gpg-sign[=]:: GPG-sign commit. would be suffic

Re: [PATCH] Add .gitconfig variable commit.gpg-sign

Joel Jacobson writes: > Signed-off-by: Joel Jacobson > --- > builtin/commit.c | 4 +++- No docs? No tests? As to the design, any regular configuration variable settings must be overridable from the command line for a single invocation. Please design an escape hatch in, for somebody who has th