Re: [PATCH] Add an EditorConfig file

2018-09-27 Thread brian m. carlson
On Mon, Sep 24, 2018 at 01:05:23PM -0700, Junio C Hamano wrote: > > Would it be helpful if I sent a script that ran during CI to ensure they > > stayed in sync for the couple places where they overlap? I'm happy to > > do so if you think it would be useful. > > It may even be an overkill. > > A

Re: [PATCH] Add an EditorConfig file

2018-09-24 Thread Junio C Hamano
"brian m. carlson" writes: >> But that is a response in a dream-world. If there is no such tool, >> I am perfectly OK if the plan is to manually keep them (loosely) in >> sync. I do not think it is good use of our time to try to come up >> with such a tool (unless somebody is really interested

Re: [PATCH] Add an EditorConfig file

2018-09-21 Thread brian m. carlson
On Thu, Sep 20, 2018 at 07:08:35AM -0700, Junio C Hamano wrote: > My comment was that it would be confusing if they gave contradicting > suggestions to the end user. After letting EditorConfig to enforce > one style while typing and saving, if "make style" suggests to > format it differently, it

Re: [PATCH] Add an EditorConfig file

2018-09-21 Thread brian m. carlson
On Thu, Sep 20, 2018 at 10:35:04PM -0400, Jeff King wrote: > On Thu, Sep 20, 2018 at 10:26:47PM -0400, Eric Sunshine wrote: > > > On Wed, Sep 19, 2018 at 8:00 PM brian m. carlson > > wrote: > > > (I am having trouble getting make style to work, though, because it > > > seems to invoke

Re: [PATCH] Add an EditorConfig file

2018-09-20 Thread Jeff King
On Thu, Sep 20, 2018 at 10:26:47PM -0400, Eric Sunshine wrote: > On Wed, Sep 19, 2018 at 8:00 PM brian m. carlson > wrote: > > (I am having trouble getting make style to work, though, because it > > seems to invoke clang-format as a git subcommand, and I don't think that > > works. I may send a

Re: [PATCH] Add an EditorConfig file

2018-09-20 Thread Eric Sunshine
On Wed, Sep 19, 2018 at 8:00 PM brian m. carlson wrote: > (I am having trouble getting make style to work, though, because it > seems to invoke clang-format as a git subcommand, and I don't think that > works. I may send a patch.) You're probably missing this piece:

Re: [PATCH] Add an EditorConfig file

2018-09-20 Thread Junio C Hamano
"brian m. carlson" writes: > I think "make style" and the EditorConfig file are complementary. "make > style" autoformats code into a diff. I agree that if we always used > clang-format to format code, then this would be a non-issue in the > EditorConfig file, since we'd just tell people to

Re: [PATCH] Add an EditorConfig file

2018-09-19 Thread brian m. carlson
On Mon, Sep 17, 2018 at 07:18:50PM -0400, Taylor Blau wrote: > Hi brian, > > Thanks for CC-ing me on this. > > I use editorconfig every day via the configuration in my home directory > [1], and the Vim plugin editorconfig-vim [2]. It's a great piece of > software, and I've been using it without

Re: [PATCH] Add an EditorConfig file

2018-09-19 Thread brian m. carlson
On Tue, Sep 18, 2018 at 08:00:27PM -0700, Junio C Hamano wrote: > "brian m. carlson" writes: > > > To make automatically configuring one's editor easier, provide an > > EditorConfig file. This is an INI-style configuration file that can be > > used to specify editor settings and can be

Re: [PATCH] Add an EditorConfig file

2018-09-18 Thread Junio C Hamano
"brian m. carlson" writes: > To make automatically configuring one's editor easier, provide an > EditorConfig file. This is an INI-style configuration file that can be > used to specify editor settings and can be understood by a wide variety > of editors. Some editors include this support

Re: [PATCH] Add an EditorConfig file

2018-09-17 Thread Taylor Blau
Hi brian, Thanks for CC-ing me on this. I use editorconfig every day via the configuration in my home directory [1], and the Vim plugin editorconfig-vim [2]. It's a great piece of software, and I've been using it without any issue since around the beginning of 2015. On Mon, Sep 17, 2018 at

[PATCH] Add an EditorConfig file

2018-09-17 Thread brian m. carlson
Contributors to Git use a variety of editors, each with their own configuration files. Because C lacks the defined norms on how to indent and style code that other languages, such as Ruby and Rust, have, it's possible for various contributors, especially new ones, to have configured their editor