Re: [PATCH] Add initial support for pax extended attributes

2018-05-23 Thread Junio C Hamano
Jeff King writes: > I do think we'd fail to notice the truncation, which isn't ideal. But it > looks like the rest of the script suffers from the same issue. > > If anybody cares, it might not be too hard to wrap all of the 512-byte > read calls into a helper that dies on bogus

Re: [PATCH] Add initial support for pax extended attributes

2018-05-22 Thread Jeff King
On Wed, May 23, 2018 at 11:34:52AM +0900, Junio C Hamano wrote: > > @@ -90,13 +99,32 @@ foreach my $tar_file (@ARGV) > > Z8 Z1 Z100 Z6 > > Z2 Z32 Z32 Z8 Z8 Z*', $_; > > } > > - next if $name =~ m{/\z}; > > $mode = oct

Re: [PATCH] Add initial support for pax extended attributes

2018-05-22 Thread Junio C Hamano
Pedro Alvarez <pedro.alva...@codethink.co.uk> writes: > From: Pedro Alvarez Piedehierro <palvare...@gmail.com> > Subject: [PATCH] Add initial support for pax extended attributes Lead it with the name of the area you are adding support for pax ext header, e.g. Subject: [

[PATCH] Add initial support for pax extended attributes

2018-05-22 Thread Pedro Alvarez
From: Pedro Alvarez Piedehierro Sometimes the tar files will contain pax extended attributes to deal with cases where the information needed doesn't fit in a standard ustar entry. One of these cases is when the path is larger than 100 characters. A pax entry will appear